Skip to content

Commit 749d59d

Browse files
authored
TST: troubleshoot strict=False xfails (#49820)
* TST: troubleshoot strict=False xfails * restore some * revert * remove xfail * remove xfail * restore test_area_lim, tighten a little bit * revert * remove xfail * revert * re-strict * more specific
1 parent d050408 commit 749d59d

File tree

3 files changed

+1
-16
lines changed

3 files changed

+1
-16
lines changed

pandas/tests/base/test_unique.py

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -105,9 +105,6 @@ def test_nunique_null(null_obj, index_or_series_obj):
105105

106106

107107
@pytest.mark.single_cpu
108-
@pytest.mark.xfail(
109-
reason="Flaky in the CI. Remove once CI has a single build: GH 44584", strict=False
110-
)
111108
def test_unique_bad_unicode(index_or_series):
112109
# regression test for #34550
113110
uval = "\ud83d" # smiley emoji

pandas/tests/computation/test_eval.py

Lines changed: 0 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -860,19 +860,6 @@ def test_basic_frame_series_alignment(
860860
def test_basic_series_frame_alignment(
861861
self, request, engine, parser, index_name, r_idx_type, c_idx_type
862862
):
863-
if (
864-
engine == "numexpr"
865-
and parser == "pandas"
866-
and index_name == "index"
867-
and r_idx_type == "i"
868-
and c_idx_type == "s"
869-
):
870-
reason = (
871-
f"Flaky column ordering when engine={engine}, "
872-
f"parser={parser}, index_name={index_name}, "
873-
f"r_idx_type={r_idx_type}, c_idx_type={c_idx_type}"
874-
)
875-
request.node.add_marker(pytest.mark.xfail(reason=reason, strict=False))
876863
df = tm.makeCustomDataframe(
877864
10, 7, data_gen_f=f, r_idx_type=r_idx_type, c_idx_type=c_idx_type
878865
)

pandas/tests/extension/json/test_json.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -277,6 +277,7 @@ def test_combine_add(self, data_repeated):
277277
reason="combine for JSONArray not supported - "
278278
"may pass depending on random data",
279279
strict=False,
280+
raises=AssertionError,
280281
)
281282
def test_combine_first(self, data):
282283
super().test_combine_first(data)

0 commit comments

Comments
 (0)