Skip to content

Conversation

@ivanpauno
Copy link
Collaborator

  • Add setters to QoSProfile.
  • Add static methods that return a mutable version of the default profiles.
  • Support for liveliness, lifespan and deadline QoS policies.
  • Simpler QoSProfile constructor.

I think that it makes sense to update this before moving forward with QoS introspection methods.

Signed-off-by: Ivan Santiago Paunovic <[email protected]>
Signed-off-by: Ivan Santiago Paunovic <[email protected]>
Signed-off-by: Ivan Santiago Paunovic <[email protected]>
@ivanpauno ivanpauno added the enhancement New feature or request label Aug 24, 2020
@ivanpauno ivanpauno requested a review from jacobperron August 24, 2020 15:37
@ivanpauno ivanpauno self-assigned this Aug 24, 2020
Signed-off-by: Ivan Santiago Paunovic <[email protected]>
Signed-off-by: Ivan Santiago Paunovic <[email protected]>
Signed-off-by: Ivan Santiago Paunovic <[email protected]>
@ivanpauno ivanpauno requested a review from jacobperron August 24, 2020 21:08
Signed-off-by: Ivan Santiago Paunovic <[email protected]>
Copy link

@jacobperron jacobperron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Signed-off-by: Ivan Santiago Paunovic <[email protected]>
@ivanpauno ivanpauno merged commit 88e1603 into foxy-devel Aug 24, 2020
@ivanpauno ivanpauno deleted the ivanpauno/update-qos-profile branch August 24, 2020 21:53
@ivanpauno ivanpauno mentioned this pull request Sep 1, 2020
1 task
ivanpauno added a commit that referenced this pull request May 17, 2021
Signed-off-by: Ivan Santiago Paunovic <[email protected]>
ivanpauno added a commit to ros2-java/ros2_java that referenced this pull request Dec 3, 2021
Signed-off-by: Ivan Santiago Paunovic <[email protected]>
ivanpauno added a commit to ros2-java/ros2_java that referenced this pull request Dec 3, 2021
Compatibility with android

Signed-off-by: Ivan Santiago Paunovic <[email protected]>
ivanpauno added a commit to ros2-java/ros2_java that referenced this pull request Dec 3, 2021
Add missing import

Signed-off-by: Ivan Santiago Paunovic <[email protected]>
ivanpauno added a commit to ros2-java/ros2_java that referenced this pull request Dec 6, 2021
Signed-off-by: Ivan Santiago Paunovic <[email protected]>
ivanpauno added a commit to ros2-java/ros2_java that referenced this pull request Dec 6, 2021
Signed-off-by: Ivan Santiago Paunovic <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants