Port from fork: update qos profile, rcl events, message lost event #199
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jacobperron
reviewed
Dec 3, 2021
Contributor
jacobperron
left a comment
jacobperron
left a comment
There was a problem hiding this comment.
LGTM after resolving the Android build failure
Signed-off-by: Ivan Santiago Paunovic <[email protected]>
Signed-off-by: Ivan Santiago Paunovic <[email protected]>
* Create LivelinessLostEvent Signed-off-by: Ivan Santiago Paunovic <[email protected]> * Fix linking issue Signed-off-by: Ivan Santiago Paunovic <[email protected]> * Rename disposeEventHandler to removeEventHandler Signed-off-by: Ivan Santiago Paunovic <[email protected]> * Use synchronized methods in EventHandlerImpl Signed-off-by: Ivan Santiago Paunovic <[email protected]> * Use createEventHandler instead of registerEventHanlder Signed-off-by: Ivan Santiago Paunovic <[email protected]> * nit Signed-off-by: Ivan Santiago Paunovic <[email protected]> * Clarify ownership of the event handle Signed-off-by: Ivan Santiago Paunovic <[email protected]>
ivanpauno
force-pushed
the
ivanpauno/port-from-fork-1
branch
from
4f24325 to
ac52a7c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ports:
Commits messages were edited to point to the correct PRs.
I will rebase and merge this when approved.