Add subscription requested qos incompatible event #14
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Aug 20, 2020
Merged
Signed-off-by: Ivan Santiago Paunovic <[email protected]>
ivanpauno
force-pushed
the
ivanpauno/add-subscription-requested-qos-incompatible-event
branch
from
b39a75a to
1497e24
Compare
jacobperron
approved these changes
Aug 24, 2020
jacobperron
left a comment
jacobperron
left a comment
There was a problem hiding this comment.
LGTM, one minor nitpick.
Is it possible to add a test for the new event?
rcljava/src/main/cpp/org_ros2_rcljava_detail_QosIncompatibleStatus.cpp
Outdated
Show resolved
Hide resolved
Collaborator
Author
That's going to be added in next PR 😃 #15 |
Signed-off-by: Ivan Santiago Paunovic <[email protected]>
ivanpauno
deleted the
ivanpauno/add-subscription-requested-qos-incompatible-event
branch
ivanpauno
added a commit
that referenced
this pull request
Aug 31, 2020
Signed-off-by: Ivan Santiago Paunovic <[email protected]>
ivanpauno
added a commit
that referenced
this pull request
May 17, 2021
Signed-off-by: Ivan Santiago Paunovic <[email protected]>
ivanpauno
added a commit
to ros2-java/ros2_java
that referenced
this pull request
Jan 14, 2022
Signed-off-by: Ivan Santiago Paunovic <[email protected]>
ivanpauno
added a commit
to ros2-java/ros2_java
that referenced
this pull request
Jan 25, 2022
Signed-off-by: Ivan Santiago Paunovic <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR solves the problem commented here, are the mangled names are shorter now.