Add Spring web operation name handler #115
Conversation
| }; | ||
|
|
||
| /** | ||
| * Decorator to record details about the handler as log events recorded on the span. |
There was a problem hiding this comment.
It does not seem to set any logs on the span.
| /** | ||
| * Use the Spring RequestMapping's value as the span's operation name. | ||
| */ | ||
| HandlerInterceptorSpanDecorator HANDLER_SPRING_WEB_METHOD_OPERATION_NAME = new HandlerInterceptorSpanDecorator() { |
There was a problem hiding this comment.
Could you please rename this to REQUEST_MAPPING_OPERATION_NAME?
pavolloffay
left a comment
pavolloffay
left a comment
There was a problem hiding this comment.
Could you please provide a test to test this operation name?
|
any update on this? |
Do you want to use this feature? |
Yes, Currently I just copied your code in my application. It would be nice if this is made available as part of the library. |
Ok, I tried to finish this feature in this week. @pavolloffay |
…ize the default behaviour (opentracing-contrib#126)
* Finish the span when subscription is canceled * Fix licensing headers
Bumps [junit](https://github.com/junit-team/junit4) from 4.12 to 4.13.1. - [Release notes](https://github.com/junit-team/junit4/releases) - [Changelog](https://github.com/junit-team/junit4/blob/main/doc/ReleaseNotes4.12.md) - [Commits](junit-team/junit4@r4.12...r4.13.1) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
6 participants
1.Support Spring RequestMapping
2.HandlerUtils.requestMapping，if use
.path()can not get anything when use@Requestmappingso change to value()