Finish the span when subscription is canceled #134
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Thanks for the PR! Can you please fix the licensing headers of the files you changed? You just need to adjust the "to" year to |
Contributor
Author
|
Should be fine. |
zouyx
pushed a commit
to zouyx/java-spring-web
that referenced
this pull request
Dec 14, 2020
* Finish the span when subscription is canceled * Fix licensing headers
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello!
With this PR, spans bound to canceled subscriptions will be also finished.
Cf this issue: #133
As span finishement is a key behavior, I added a set of tests asserting this action for all the final signals: complete, error, and canceled.
Thanks @geoand.