Skip to content

Conversation

@geoand
Copy link
Collaborator

@geoand geoand commented Aug 22, 2019

Resolves #121

@geoand
Copy link
Collaborator Author

geoand commented Aug 22, 2019

Opened the PR as a draft, because one of the dependencies has not yet hit Maven Central

@geoand
Copy link
Collaborator Author

geoand commented Aug 26, 2019

io.opentacing.contrib:opentracing-spring-tracer-configuration-starter:0.3.0 still not on Maven Central so I did a new 0.3.1 release and will update this PR once it's ready

@geoand
Copy link
Collaborator Author

geoand commented Aug 28, 2019

@pavolloffay any idea why the releases of io.opentacing.contrib:opentracing-spring-tracer-configuration-starter seem to not be making it to Maven Central?

@pavolloffay
Copy link
Collaborator

pavolloffay commented Aug 28, 2019

First I check the builds https://travis-ci.org/opentracing-contrib/java-spring-tracer-configuration/builds.
It seems that sync to central failed https://travis-ci.org/opentracing-contrib/java-spring-tracer-configuration/builds/576688050#L880

Then I check binray https://bintray.com/opentracing/maven/opentracing-spring-default-tracer-configuration 0.3.1 is there.

I think you have these options:

  1. sync to maven central via binray UI
  2. restart the whole process - remove release from binray and restart failed travis job
  3. push next release tag to trigger a new release

If you don't have access to binray let me know I will add you.

@geoand
Copy link
Collaborator Author

geoand commented Aug 29, 2019

Thanks @pavolloffay.

I guess that you already performed the sync from the Bintray UI? I seem to have access, so I'll do it next time

@pavolloffay
Copy link
Collaborator

I haven't synced it.

@geoand
Copy link
Collaborator Author

geoand commented Aug 29, 2019

OK, I'm not sure what I am supposed to use for User token key and User token password when using on the Maven Central "tab"

@pavolloffay
Copy link
Collaborator

sonatype user:pass

@geoand
Copy link
Collaborator Author

geoand commented Aug 29, 2019

Got it, thanks!

@geoand geoand closed this Oct 15, 2019
@geoand geoand reopened this Oct 15, 2019
@mattbroekhuis
Copy link

This builds locally. Can we get it released? I am guessing just re-triggering the build would do it?

@geoand geoand closed this Nov 20, 2019
@geoand geoand reopened this Nov 20, 2019
@geoand
Copy link
Collaborator Author

geoand commented Nov 20, 2019

I restarted it, lets see what happens

@geoand geoand marked this pull request as ready for review November 20, 2019 16:04
@geoand
Copy link
Collaborator Author

geoand commented Nov 20, 2019

@pavolloffay Can you please review when you have some time?

@ttddyy
Copy link

ttddyy commented Nov 29, 2019

Hi,
I am waiting this version bump to happen as well.

What is the plan here?
Are you going to release new version soon? When would it be?

We are in need for this change, and if it doesn't happen, we need to re-evaluate our upgrades with opentracing API v0.33.

So, appreciate merge and release would happen soon.

Thanks,

@geoand
Copy link
Collaborator Author

geoand commented Nov 29, 2019

I will merge and do a 3.x release on Monday unless you have any objections @pavolloffay

@pavolloffay
Copy link
Collaborator

+1 go ahead

@geoand geoand merged commit f64f87e into master Nov 30, 2019
@geoand geoand deleted the ot-0.33 branch November 30, 2019 09:11
@geoand
Copy link
Collaborator Author

geoand commented Nov 30, 2019

I just released version 3.0.0. It should hopefully be in Maven Central in less than 24h

@ttddyy
Copy link

ttddyy commented Nov 30, 2019

@geoand @pavolloffay Thanks!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

upgrade to opentracing 0.33.0

5 participants