Add OIDC Timeout config options to NIC ConfigMap #1410

AlexFenlon · 2025-11-06T16:57:12Z

Proposed changes

Add OIDC Timeout config options to NIC ConfigMap

code pr:
nginx/kubernetes-ingress#8495

Checklist

Before sharing this pull request, I completed the following checklist:

I read the Contributing guidelines
My branch adheres to the Git conventions
My content changes adhere to the F5 NGINX Documentation style guide
If my changes involve potentially sensitive information¹, I have assessed the possible impact
I have waited to ensure my changes pass tests, and addressed any discovered issues

Potentially sensitive information includes personally identify information (PII), authentication credentials, and live URLs. Refer to the style guide for guidance about placeholder content. ↩

workaround for an NGF callout render issue

* fix: Update nim-app-protect-support.md * fix : Add NAP 5.9.0 version info to NIM * Update content/nim/nginx-app-protect/setup-waf-config-management.md * Update content/nim/nginx-app-protect/setup-waf-config-management.md Co-authored-by: Jon Torre <[email protected]> * Update content/nim/nginx-app-protect/setup-waf-config-management.md Co-authored-by: Mike Jang <[email protected]> * Update content/nim/nginx-app-protect/setup-waf-config-management.md Co-authored-by: Jon Torre <[email protected]> --------- Co-authored-by: Mike Jang <[email protected]> Co-authored-by: Jon Torre <[email protected]>

fix: Update per WAF refactor

Added flowcarts for NGINX Plus license verification and usage reporting requirements. Simplified language in Getting Started guide. --------- Co-authored-by: Mike Jang <[email protected]> Co-authored-by: yar <[email protected]>

* Update linkchecker.yml * Update linkchecker.yml Add https://my-deployment.my-region.nginxaas.net/connectivity to ignore list * Update linkchecker.yml --------- Co-authored-by: Jack Hickey <[email protected]>

various WAF typo fixes

* Update linkchecker.yml Update with new waf endpoint name

* Add example to show users how to set NGINX_AGENT_LABELS * Update content/nginx-one/agent/configure-instances/configuration-overview.md Thank you! Co-authored-by: Jon Torre <[email protected]> --------- Co-authored-by: Jon Torre <[email protected]>

Removes restriction on the combination of both precompiled and custom policies in an NGINX config.

* fix: remore NGINXaaS mention on N4A known issues

Update NGF release version 2.1.3

Update ngf version to 2.1.4

reorganize N4A changelog docs

This commit updates the F5 WAF for NGINX changelog to add the remaining entries for 2025 and the entries from 2024 where the product diverged into the V4 and V5 labels. As part of migrating the content, feature links are updated to reflect recent documentation restructuring, and package names were combined into singular tables to reflect the new style convention.

Updated the description for XML and JSON content to clarify that profiles detect malformed content and signatures.

feat: templates and app-protect signatures api Co-authored-by: Mike Jang <[email protected]>

* Content from F5 user vrmare in internal repo * Update content/nginx-one/nginx-configs/config-templates/author-templates.md * Update content/nginx-one/nginx-configs/config-templates/import-templates.md * Update content/nginx-one/nginx-configs/config-templates/author-templates.md * Add changelog * Apply suggestions from code review Co-authored-by: Travis Martin <[email protected]> * Apply suggestions from code review --------- Co-authored-by: Travis Martin <[email protected]>

Closes #1199, #1210, #1214, #125, #1218, #1219

* docs: add config agent features --------- Co-authored-by: Alan Dooley <[email protected]>

Removed 'connection' and 'agent-api' features from launch and environment variable examples. as these don't apply to v3

* docs: Revamp NGINX technical specs summary table * docs: delete RHEL 10 row * Update content/nginx/technical-specs.md Co-authored-by: yar <[email protected]> * Update content/nginx/technical-specs.md Co-authored-by: yar <[email protected]> * Update content/nginx/technical-specs.md Co-authored-by: yar <[email protected]> * Update content/nginx/technical-specs.md Co-authored-by: yar <[email protected]> * update * Update content/nginx/technical-specs.md --------- Co-authored-by: chisomuma <[email protected]> Co-authored-by: Mike Jang <[email protected]> Co-authored-by: yar <[email protected]>

This commit uses the shortcode psuedo-variable pattern to make multiple component versions for F5 WAF for NGINX into strings. This allows for content in multiple locations to be changed at once by updating the file relating to the version. Many of the versions are currently identical: if the individual components all use the same version, then the amount of shortcode files can be reduced accordingly. - Closes #1318 by replacing the string with a shortcode - Closes #1364 by creating shortcode psuedovariables for each item

Co-authored-by: Alan Dooley <[email protected]> Co-authored-by: Mike Jang <[email protected]>

Move from IaaS phrasing, place partner cloud first Co-authored-by: Mike Jang <[email protected]>

The documentation mentions 2 physical server, implying the configuration can only be applied when hardware servers are being used not virtual machines. However below that There are some caveats about using cloud platforms (implying it would be possible to apply this configuration to the cloud as well) "Some cloud platforms don’t allow direct IP management with keepalived. If you’re using a cloud environment, check whether it supports VIP assignment."

* chore: update CODEOWNERS for NGINXaaS for GC

Remove EPP flags

content/nic/configuration/global-configuration/configmap-resource.md

github-actions · 2025-11-06T17:00:05Z

✅ Deploy Preview will be available once build job completes!

Name	Link
😎 Deploy Preview	https://frontdoor-test-docs.nginx.com/previews/docs/1410/

content/nic/configuration/global-configuration/configmap-resource.md

targeting wrong branch

ADubhlaoich · 2025-11-06T17:04:16Z

content/nic/configuration/global-configuration/configmap-resource.md

+### OIDC (OpenID Connect) Timeouts
+For more information on timeouts, see [here](https://github.com/nginxinc/nginx-openid-connect?tab=readme-ov-file#configuring-the-key-value-store)


Suggested change

### OIDC (OpenID Connect) Timeouts

For more information on timeouts, see [here](https://github.com/nginxinc/nginx-openid-connect?tab=readme-ov-file#configuring-the-key-value-store)

### OIDC (OpenID Connect) Timeouts

For more information on timeouts, see [here](https://github.com/nginxinc/nginx-openid-connect?tab=readme-ov-file#configuring-the-key-value-store)

ADubhlaoich · 2025-11-06T17:04:23Z

content/nic/configuration/global-configuration/configmap-resource.md

+| *oidc-access-tokens-timeout* | Sets the timeout for access tokens in OIDC. | `1h` |
+| *oidc-refresh-tokens-timeout* | Sets the timeout for refresh tokens in OIDC. | `24h` |
+| *oidc-sids-timeout* | Sets the timeout for session IDs in OIDC. | `24h` |
+


Suggested change

ADubhlaoich

LGTM: edit suggestions for Markdown formatting.

You can discover these formatting issues with our linting tools: I suggest getting used to using them with pre-commit before they are enforced as part of the CI/CD pipeline.

github-actions · 2025-11-07T09:30:25Z

🎉 Thank you for your contribution! It appears you have not yet signed the F5 Contributor License Agreement (CLA), which is required for your changes to be incorporated into an F5 Open Source Software (OSS) project. Please kindly read the F5 CLA and reply on a new comment with the following text to agree:

I have hereby read the F5 CLA and agree to its terms

31 out of 32 committers have signed the CLA.
✅ (JTorreG)[https://github.com/JTorreG]
✅ (vvnginx)[https://github.com/vvnginx]
✅ (mjang)[https://github.com/mjang]
✅ (lamATnginx)[https://github.com/lamATnginx]
✅ (travisamartin)[https://github.com/travisamartin]
✅ (nginx-aoife)[https://github.com/nginx-aoife]
✅ (aknot242)[https://github.com/aknot242]
✅ (nginx-seanmoloney)[https://github.com/nginx-seanmoloney]
✅ (edarzins)[https://github.com/edarzins]
✅ (bjee19)[https://github.com/bjee19]
✅ (pdabelf5)[https://github.com/pdabelf5]
✅ (ADubhlaoich)[https://github.com/ADubhlaoich]
✅ (vrmare)[https://github.com/vrmare]
✅ (ChisomUma)[https://github.com/ChisomUma]
✅ (sylwang)[https://github.com/sylwang]
✅ (nginx-jack)[https://github.com/nginx-jack]
✅ (Naveen-Gopu-F5)[https://github.com/Naveen-Gopu-F5]
✅ (mmaheswaran-f5)[https://github.com/mmaheswaran-f5]
✅ (kafeelhasan)[https://github.com/kafeelhasan]
✅ (russokj)[https://github.com/russokj]
✅ (rishabh-f5)[https://github.com/rishabh-f5]
✅ (y82)[https://github.com/y82]
✅ (vepatel)[https://github.com/vepatel]
✅ (cjain-f5)[https://github.com/cjain-f5]
✅ (dhurley)[https://github.com/dhurley]
✅ (AlexFenlon)[https://github.com/AlexFenlon]
✅ (valyria257)[https://github.com/valyria257]
✅ (puneetsarna)[https://github.com/puneetsarna]
✅ (jayaparthasarathyf5)[https://github.com/jayaparthasarathyf5]
✅ (shaun-nx)[https://github.com/shaun-nx]
✅ (arussellf5)[https://github.com/arussellf5]
❌ @mattdesmarais
_{You can retrigger this bot by commenting recheck in this Pull Request.}_{Posted by the CLA Assistant Lite bot.}

JTorreG and others added 30 commits September 30, 2025 16:04

fix: NGF callout formatting issue (#1196)

8c5a7db

workaround for an NGF callout render issue

Update per WAF refactor (#1202)

9ae6ffd

fix: Update per WAF refactor

chore: Pin NPM dep versions (#1201)

ee4665f

chore: Bump hugo theme version to v1.0.9 (#1203)

095f985

fix: updated the NGINX Plus startup check workflow diagram (#1205)

143c925

docs: cropped the NGINX Plus startup check flowchart (#1206)

245c5ef

Update linkchecker.yml (#1168)

8091141

* Update linkchecker.yml * Update linkchecker.yml Add https://my-deployment.my-region.nginxaas.net/connectivity to ignore list * Update linkchecker.yml --------- Co-authored-by: Jack Hickey <[email protected]>

fix: typos in waf content (#1204)

0fd8670

various WAF typo fixes

Update linkchecker waf url (#1208)

2b87027

* Update linkchecker.yml Update with new waf endpoint name

chore: remove cloudcannon files (#1195)

1b6095b

Remove restriction on combination of WAF policies (#1181)

e4626d8

Removes restriction on the combination of both precompiled and custom policies in an NGINX config.

fix: remore NGINXaaS mention on N4A known issues (#1213)

51cf156

* fix: remore NGINXaaS mention on N4A known issues

NGF: Update release version 2.1.3 (#1220)

c43ef91

Update NGF release version 2.1.3

NGF: Update release version to 2.1.4 (#1222)

3206749

Update ngf version to 2.1.4

NIC: Add securityLogs table to WAF policy (#1224)

e7e71f5

Fix formatting of deprecation note in policy-resource.md (#1225)

071e0bd

docs: reorg. N4A docs (#1186)

4c57e0d

reorganize N4A changelog docs

docs: WAF/Clarify XML and JSON content description (#1228)

0ced94d

Updated the description for XML and JSON content to clarify that profiles detect malformed content and signatures.

fix: Typo in XML and JSON content description (#1231)

775efce

feat: templates and app-protect signature-sets api (#1221)

3271f69

feat: templates and app-protect signatures api Co-authored-by: Mike Jang <[email protected]>

feat: Minor WAF fixes (#1230)

839a514

Closes #1199, #1210, #1214, #125, #1218, #1219

feat: Add violations page for F5 WAF for NGINX (#1239)

2358d56

docs: Agent/add missing doc (#1207)

9628ae5

* docs: add config agent features --------- Co-authored-by: Alan Dooley <[email protected]>

docs: Update agent features configuration examples (#1260)

3243d21

Removed 'connection' and 'agent-api' features from launch and environment variable examples. as these don't apply to v3

ADubhlaoich and others added 9 commits November 5, 2025 12:22

docs: move community to root (#1396)

b7a2e37

Co-authored-by: Alan Dooley <[email protected]> Co-authored-by: Mike Jang <[email protected]>

Update the tag line and description (#1387)

e8e0d0a

Move from IaaS phrasing, place partner cloud first Co-authored-by: Mike Jang <[email protected]>

Update release page (#1405)

4367024

NGINXaaS: add enable cloud logging api to prereqs (#1404)

8aeaa0f

chore: update CODEOWNERS for NGINXaaS for GC (#1408)

e3a2464

* chore: update CODEOWNERS for NGINXaaS for GC

NGF: Remove EPP flags until release (#1403)

80ba757

Remove EPP flags

Add OIDC Timeout config options to NIC ConfigMap

c5872e9

AlexFenlon requested a review from a team as a code owner November 6, 2025 16:57

github-actions bot added documentation Improvements or additions to documentation product/nic Issues related to NGINX Ingress Controller labels Nov 6, 2025

AlexFenlon commented Nov 6, 2025

View reviewed changes

content/nic/configuration/global-configuration/configmap-resource.md Show resolved Hide resolved

Apply suggestions from code review

fd08a95

vepatel previously approved these changes Nov 6, 2025

View reviewed changes

AlexFenlon commented Nov 6, 2025

View reviewed changes

content/nic/configuration/global-configuration/configmap-resource.md Outdated Show resolved Hide resolved

Fix link

f24f0e8

ADubhlaoich reviewed Nov 6, 2025

View reviewed changes

ADubhlaoich approved these changes Nov 6, 2025

View reviewed changes

AlexFenlon changed the base branch from main to nic-release-5.3 November 7, 2025 09:29

AlexFenlon requested review from a team as code owners November 7, 2025 09:29

AlexFenlon closed this Nov 7, 2025

AlexFenlon deleted the nic/oidc-timeout-configmap branch November 7, 2025 09:33

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Add OIDC Timeout config options to NIC ConfigMap #1410

Add OIDC Timeout config options to NIC ConfigMap #1410

Uh oh!

AlexFenlon commented Nov 6, 2025

Uh oh!

Uh oh!

github-actions bot commented Nov 6, 2025

Uh oh!

Uh oh!

ADubhlaoich Nov 6, 2025

Uh oh!

ADubhlaoich Nov 6, 2025

Uh oh!

ADubhlaoich left a comment

Uh oh!

github-actions bot commented Nov 7, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

20 participants

		### OIDC (OpenID Connect) Timeouts
		For more information on timeouts, see [here](https://github.com/nginxinc/nginx-openid-connect?tab=readme-ov-file#configuring-the-key-value-store)

Add OIDC Timeout config options to NIC ConfigMap #1410

Add OIDC Timeout config options to NIC ConfigMap #1410

Uh oh!

Conversation

AlexFenlon commented Nov 6, 2025

Proposed changes

Checklist

Footnotes

Uh oh!

Uh oh!

github-actions bot commented Nov 6, 2025

✅ Deploy Preview will be available once build job completes!

Uh oh!

Uh oh!

ADubhlaoich Nov 6, 2025

Choose a reason for hiding this comment

Uh oh!

ADubhlaoich Nov 6, 2025

Choose a reason for hiding this comment

Uh oh!

ADubhlaoich left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions bot commented Nov 7, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

20 participants