Skip to content

Conversation

@vvnginx
Copy link
Contributor

@vvnginx vvnginx commented Sep 30, 2025

Proposed changes

Checklist

Before sharing this pull request, I completed the following checklist:

Footnotes

  1. Potentially sensitive information includes personally identify information (PII), authentication credentials, and live URLs. Refer to the style guide for guidance about placeholder content.

@vvnginx vvnginx requested a review from a team as a code owner September 30, 2025 08:31
@github-actions github-actions bot added documentation Improvements or additions to documentation product/nim Issues related to NGINX Instance Manager labels Sep 30, 2025
Copy link
Contributor

@mjang mjang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving with one comment. Since NAP 5.9 is being released today, and my suggestion is limited to syntax/style, my next step will be to "accept" the change and push to the local (internal) chat for review.

@vvnginx vvnginx enabled auto-merge (squash) September 30, 2025 15:13
@vvnginx vvnginx disabled auto-merge September 30, 2025 15:41
@mjang mjang merged commit 296a336 into nginx:main Sep 30, 2025
6 checks passed
pdabelf5 pushed a commit that referenced this pull request Oct 22, 2025
* fix: Update nim-app-protect-support.md

* fix : Add NAP 5.9.0 version info to NIM

* Update content/nim/nginx-app-protect/setup-waf-config-management.md

* Update content/nim/nginx-app-protect/setup-waf-config-management.md

Co-authored-by: Jon Torre <[email protected]>

* Update content/nim/nginx-app-protect/setup-waf-config-management.md

Co-authored-by: Mike Jang <[email protected]>

* Update content/nim/nginx-app-protect/setup-waf-config-management.md

Co-authored-by: Jon Torre <[email protected]>

---------

Co-authored-by: Mike Jang <[email protected]>
Co-authored-by: Jon Torre <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation product/nim Issues related to NGINX Instance Manager

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants