Skip to content

Use pre-packaged-source for pie downloads #1782

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 28, 2025

Conversation

asgrim
Copy link
Contributor

@asgrim asgrim commented Feb 4, 2025

We worked on php/pie#39 to allow the mongodb extension to be built from pre-packaged source URLs instead of relying on the git-generated ZIP archive that GitHub etc. uses (and thus Composer/PIE).

Note: build-path is also needed, and I added a template for it, since the TGZ produced has a subdirectory in it based on the version; so in the case of mongodb at least, we'll need both download-url-method and build-path to be specified.

Note 2: needs php/pie#187 to be merged first

composer.json Outdated
@@ -17,6 +17,8 @@
},
"php-ext": {
"extension-name": "mongodb",
"override-download-url-method": "pre-packaged-source",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs php/pie#187 to be merged before this will work

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Above is merged, release will be very soon, just finishing off the uninstall feature in PIE and will make a next release :)

@asgrim asgrim force-pushed the allow-install-with-pie branch from a528c49 to eb302a9 Compare February 5, 2025 10:34
@alcaeus alcaeus marked this pull request as ready for review February 28, 2025 08:07
@alcaeus alcaeus changed the title Override PIE download URL and set build-path for pre-packaged source Use pre-packaged-source for pie downloads Feb 28, 2025
@alcaeus alcaeus force-pushed the allow-install-with-pie branch 2 times, most recently from dce5419 to 2ca4816 Compare February 28, 2025 08:48
@alcaeus alcaeus enabled auto-merge (squash) February 28, 2025 08:49
@alcaeus alcaeus merged commit 94692b7 into mongodb:v1.x Feb 28, 2025
59 checks passed
@asgrim asgrim deleted the allow-install-with-pie branch February 28, 2025 09:08
netbsd-srcmastr pushed a commit to NetBSD/pkgsrc that referenced this pull request Mar 2, 2025
1.21.0

What's Changed

* PHPC-2343: Require PHP 8.1 by @alcaeus in
  mongodb/mongo-php-driver#1631

* Update branch names for GHA workflows by @alcaeus in
  mongodb/mongo-php-driver#1646

* Bump version to 1.21-dev by @alcaeus in
  mongodb/mongo-php-driver#1661

* Document how to run part of the test suite by @GromNaN in
  mongodb/mongo-php-driver#1690

* PHPC-2458: Deprecate float arg for UTCDateTime constructor by @jmikola in
  mongodb/mongo-php-driver#1695

* PHPC-2464: Emit deprecation notice for negative "limit" Query option by
  @jmikola in mongodb/mongo-php-driver#1710

* PHPC-2460: Use zend_zval_type_name instead of internal macros by @jmikola
  in mongodb/mongo-php-driver#1714

* PHPC-1247: Update links to PHP.net docs by @jmikola in
  mongodb/mongo-php-driver#1735

* Test PPC and Zseries on RHEL 9 by @alcaeus in
  mongodb/mongo-php-driver#1740

* PHPC-2472: Update to libmongocrypt 1.12.0 by @jmikola in
  mongodb/mongo-php-driver#1743

* PHPC-2473: Bump to libmongoc 1.29.0 by @jmikola in
  mongodb/mongo-php-driver#1748

* PHPC-2471: Sync BSON corpus tests for Y10K date parsing by @jmikola in
  mongodb/mongo-php-driver#1742

* Use correct arch name in Windows artifacts. by @mickverm in
  mongodb/mongo-php-driver#1762

* PHPC-2499: Update to libmongoc 1.29.2 by @jmikola in
  mongodb/mongo-php-driver#1766

* PHPC-2496: WriteException stub should inherit ServerException by @jmikola
  in mongodb/mongo-php-driver#1769

* PHPC-2477: Remove unused libmongoc and libbson constants by @jmikola in
  mongodb/mongo-php-driver#1768

* PHPC-2502: Remove XFAIL in server-executeQuery-012.phpt by @jmikola in
  mongodb/mongo-php-driver#1772

* PHPC-2489: Deprecate passing WriteConcern and ReadPreference objects to
  execute methods by @jmikola in
  mongodb/mongo-php-driver#1770

* PHPC-2501: Conditionally define MONGOC_CYRUS_PLUGIN_PATH_PREFIX on Windows
  by @jmikola in mongodb/mongo-php-driver#1777

* PHPC-2503: Conditionally allow more concise output for libbson 1.30 by
  @jmikola in mongodb/mongo-php-driver#1779

* PHPC:2498: Accept integer types for Document array access by @jmikola in
  mongodb/mongo-php-driver#1781

* PHPC-2508 and PHPC-2506: Bump libmongoc to 1.30 by @jmikola in
  mongodb/mongo-php-driver#1785

* PHPC-2513: Check for returned _id before appending insert by @jmikola in
  mongodb/mongo-php-driver#1788

* PHPC-2519: Bump libmongoc to 1.30.1 by @jmikola in
  mongodb/mongo-php-driver#1792

* PHPC-2518: Support sort option for updateOne and replaceOne by @jmikola in
  mongodb/mongo-php-driver#1794

* Use pre-packaged-source for pie downloads by @asgrim in
  mongodb/mongo-php-driver#1782

New Contributors

* @asgrim made their first contribution in
  mongodb/mongo-php-driver#1782
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants