PHPC-2477: Remove unused libmongoc and libbson constants #1768
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CDRIVER-4124 removed BSON_HAVE_ATOMIC_32_ADD_AND_FETCH and BSON_HAVE_ATOMIC_64_ADD_AND_FETCH
CDRIVER-2694 removed BSON_PTHREAD_ONCE_INIT_NEEDS_BRACES
BSON_HAVE_REALLOCF was no longer used when libbson was vendored in CDRIVER-2416
CDRIVER-2771 removed outstanding references to BSON_HAVE_SYSCALL_TID
CDRIVER-2654 removed MONGOC_ENABLE_SASL_GSSAPI. PHPC-2312 removed it from Autotools, but it was left behind in config.w32.
CDRIVER-2600 removed MONGOC_HAVE_WEAK_SYMBOLS
alcaeus
approved these changes
Jan 29, 2025
There was a problem hiding this comment.
Changes LGTM. I think build failures are related to drivers-evergreen-tools updates, so let's see if mongodb/mongo-php-library#1578 fixes this.
This was referenced Jan 29, 2025
Merged
Closed
Closed
Closed
Merged
netbsd-srcmastr
pushed a commit
to NetBSD/pkgsrc
that referenced
this pull request
Mar 2, 2025
1.21.0 What's Changed * PHPC-2343: Require PHP 8.1 by @alcaeus in mongodb/mongo-php-driver#1631 * Update branch names for GHA workflows by @alcaeus in mongodb/mongo-php-driver#1646 * Bump version to 1.21-dev by @alcaeus in mongodb/mongo-php-driver#1661 * Document how to run part of the test suite by @GromNaN in mongodb/mongo-php-driver#1690 * PHPC-2458: Deprecate float arg for UTCDateTime constructor by @jmikola in mongodb/mongo-php-driver#1695 * PHPC-2464: Emit deprecation notice for negative "limit" Query option by @jmikola in mongodb/mongo-php-driver#1710 * PHPC-2460: Use zend_zval_type_name instead of internal macros by @jmikola in mongodb/mongo-php-driver#1714 * PHPC-1247: Update links to PHP.net docs by @jmikola in mongodb/mongo-php-driver#1735 * Test PPC and Zseries on RHEL 9 by @alcaeus in mongodb/mongo-php-driver#1740 * PHPC-2472: Update to libmongocrypt 1.12.0 by @jmikola in mongodb/mongo-php-driver#1743 * PHPC-2473: Bump to libmongoc 1.29.0 by @jmikola in mongodb/mongo-php-driver#1748 * PHPC-2471: Sync BSON corpus tests for Y10K date parsing by @jmikola in mongodb/mongo-php-driver#1742 * Use correct arch name in Windows artifacts. by @mickverm in mongodb/mongo-php-driver#1762 * PHPC-2499: Update to libmongoc 1.29.2 by @jmikola in mongodb/mongo-php-driver#1766 * PHPC-2496: WriteException stub should inherit ServerException by @jmikola in mongodb/mongo-php-driver#1769 * PHPC-2477: Remove unused libmongoc and libbson constants by @jmikola in mongodb/mongo-php-driver#1768 * PHPC-2502: Remove XFAIL in server-executeQuery-012.phpt by @jmikola in mongodb/mongo-php-driver#1772 * PHPC-2489: Deprecate passing WriteConcern and ReadPreference objects to execute methods by @jmikola in mongodb/mongo-php-driver#1770 * PHPC-2501: Conditionally define MONGOC_CYRUS_PLUGIN_PATH_PREFIX on Windows by @jmikola in mongodb/mongo-php-driver#1777 * PHPC-2503: Conditionally allow more concise output for libbson 1.30 by @jmikola in mongodb/mongo-php-driver#1779 * PHPC:2498: Accept integer types for Document array access by @jmikola in mongodb/mongo-php-driver#1781 * PHPC-2508 and PHPC-2506: Bump libmongoc to 1.30 by @jmikola in mongodb/mongo-php-driver#1785 * PHPC-2513: Check for returned _id before appending insert by @jmikola in mongodb/mongo-php-driver#1788 * PHPC-2519: Bump libmongoc to 1.30.1 by @jmikola in mongodb/mongo-php-driver#1792 * PHPC-2518: Support sort option for updateOne and replaceOne by @jmikola in mongodb/mongo-php-driver#1794 * Use pre-packaged-source for pie downloads by @asgrim in mongodb/mongo-php-driver#1782 New Contributors * @asgrim made their first contribution in mongodb/mongo-php-driver#1782
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://jira.mongodb.org/browse/PHPC-2477