Skip to content

Document how to run part of the test suite #1690

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 24, 2024

Conversation

GromNaN
Copy link
Member

@GromNaN GromNaN commented Sep 24, 2024

No description provided.

@GromNaN GromNaN requested review from alcaeus and jmikola and removed request for alcaeus September 24, 2024 15:05
Copy link
Member

@jmikola jmikola left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Optional suggestion for phpize instructions.

@@ -31,7 +31,7 @@ $ php --ri mongodb
## Generating arginfo from stub files

Arginfo structures are generated from stub files using the `gen_stub.php`
file. Note that this requires `phpize` to be run for PHP 8.2 to make use
file. Note that this requires `phpize` to be run for **PHP 8.2** to make use
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this read PHP 8.2+? Locally, I've been running this with PHP 8.3 for some time.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With PHP 8.3, generated files are different: #1687 (comment)

Copy link
Member

@jmikola jmikola Sep 25, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it only PHP 8.3's gen_stub.php that has the optimization to re-use arginfo for methods? It's not clear to me what you used in that PR.

I'll note that workflows/arginfo-files.yml uses PHP 8.2, so no objections to requiring that here. If PHP 8.3 actually generates different output, I suppose CI would fail.

@GromNaN GromNaN merged commit 25de213 into mongodb:v1.x Sep 24, 2024
62 checks passed
@GromNaN GromNaN deleted the doc-contributing branch September 24, 2024 20:28
alcaeus added a commit that referenced this pull request Sep 30, 2024
* v1.x:
  PHPC-2458: Deprecate float arg for UTCDateTime constructor (#1695)
  Document how to run part of the test suite (#1690)
  Bump version to 1.21-dev (#1661)
  Update branch names for GHA workflows (#1646)
  PHPC-2343: Require PHP 8.1 (#1631)
alcaeus added a commit that referenced this pull request Oct 15, 2024
* v1.x:
  PHPC-2460: Use zend_zval_type_name instead of internal macros (#1714)
  PHPC-2464: Emit deprecation notice for negative "limit" Query option (#1710)
  PHPC-2458: Deprecate float arg for UTCDateTime constructor (#1695)
  Document how to run part of the test suite (#1690)
  Bump version to 1.21-dev (#1661)
  Update branch names for GHA workflows (#1646)
  PHPC-2343: Require PHP 8.1 (#1631)
alcaeus added a commit that referenced this pull request Oct 17, 2024
* v1.x:
  PHPC-2460: Use zend_zval_type_name instead of internal macros (#1714)
  PHPC-2464: Emit deprecation notice for negative "limit" Query option (#1710)
  PHPC-2458: Deprecate float arg for UTCDateTime constructor (#1695)
  Document how to run part of the test suite (#1690)
  Bump version to 1.21-dev (#1661)
  Update branch names for GHA workflows (#1646)
  PHPC-2343: Require PHP 8.1 (#1631)
alcaeus added a commit that referenced this pull request Oct 29, 2024
* v1.x:
  PHPC-1247: Update links to PHP.net docs (#1735)
  PHPC-2460: Use zend_zval_type_name instead of internal macros (#1714)
  PHPC-2464: Emit deprecation notice for negative "limit" Query option (#1710)
  PHPC-2458: Deprecate float arg for UTCDateTime constructor (#1695)
  Document how to run part of the test suite (#1690)
  Bump version to 1.21-dev (#1661)
  Update branch names for GHA workflows (#1646)
  PHPC-2343: Require PHP 8.1 (#1631)
netbsd-srcmastr pushed a commit to NetBSD/pkgsrc that referenced this pull request Mar 2, 2025
1.21.0

What's Changed

* PHPC-2343: Require PHP 8.1 by @alcaeus in
  mongodb/mongo-php-driver#1631

* Update branch names for GHA workflows by @alcaeus in
  mongodb/mongo-php-driver#1646

* Bump version to 1.21-dev by @alcaeus in
  mongodb/mongo-php-driver#1661

* Document how to run part of the test suite by @GromNaN in
  mongodb/mongo-php-driver#1690

* PHPC-2458: Deprecate float arg for UTCDateTime constructor by @jmikola in
  mongodb/mongo-php-driver#1695

* PHPC-2464: Emit deprecation notice for negative "limit" Query option by
  @jmikola in mongodb/mongo-php-driver#1710

* PHPC-2460: Use zend_zval_type_name instead of internal macros by @jmikola
  in mongodb/mongo-php-driver#1714

* PHPC-1247: Update links to PHP.net docs by @jmikola in
  mongodb/mongo-php-driver#1735

* Test PPC and Zseries on RHEL 9 by @alcaeus in
  mongodb/mongo-php-driver#1740

* PHPC-2472: Update to libmongocrypt 1.12.0 by @jmikola in
  mongodb/mongo-php-driver#1743

* PHPC-2473: Bump to libmongoc 1.29.0 by @jmikola in
  mongodb/mongo-php-driver#1748

* PHPC-2471: Sync BSON corpus tests for Y10K date parsing by @jmikola in
  mongodb/mongo-php-driver#1742

* Use correct arch name in Windows artifacts. by @mickverm in
  mongodb/mongo-php-driver#1762

* PHPC-2499: Update to libmongoc 1.29.2 by @jmikola in
  mongodb/mongo-php-driver#1766

* PHPC-2496: WriteException stub should inherit ServerException by @jmikola
  in mongodb/mongo-php-driver#1769

* PHPC-2477: Remove unused libmongoc and libbson constants by @jmikola in
  mongodb/mongo-php-driver#1768

* PHPC-2502: Remove XFAIL in server-executeQuery-012.phpt by @jmikola in
  mongodb/mongo-php-driver#1772

* PHPC-2489: Deprecate passing WriteConcern and ReadPreference objects to
  execute methods by @jmikola in
  mongodb/mongo-php-driver#1770

* PHPC-2501: Conditionally define MONGOC_CYRUS_PLUGIN_PATH_PREFIX on Windows
  by @jmikola in mongodb/mongo-php-driver#1777

* PHPC-2503: Conditionally allow more concise output for libbson 1.30 by
  @jmikola in mongodb/mongo-php-driver#1779

* PHPC:2498: Accept integer types for Document array access by @jmikola in
  mongodb/mongo-php-driver#1781

* PHPC-2508 and PHPC-2506: Bump libmongoc to 1.30 by @jmikola in
  mongodb/mongo-php-driver#1785

* PHPC-2513: Check for returned _id before appending insert by @jmikola in
  mongodb/mongo-php-driver#1788

* PHPC-2519: Bump libmongoc to 1.30.1 by @jmikola in
  mongodb/mongo-php-driver#1792

* PHPC-2518: Support sort option for updateOne and replaceOne by @jmikola in
  mongodb/mongo-php-driver#1794

* Use pre-packaged-source for pie downloads by @asgrim in
  mongodb/mongo-php-driver#1782

New Contributors

* @asgrim made their first contribution in
  mongodb/mongo-php-driver#1782
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants