Skip to content

Conversation

@casella
Copy link
Contributor

@casella casella commented Mar 4, 2025

This attempts to fix #4559 by making the system less brutally nonlinear when approaching zero voltage and current on the load towards the end of the transient.

@casella casella requested review from AHaumer and christiankral March 4, 2025 17:43
@beutlich beutlich changed the title Attempt to fix 4559 by increasing RonDiode and GoffDiode Attempt to fix #4559 by increasing RonDiode and GoffDiode Mar 4, 2025
@beutlich beutlich added L: Magnetic.FundamentalWave Issue addresses Modelica.Magnetic.FundamentalWave example Issue only addresses example(s) labels Mar 4, 2025
@casella casella requested a review from maltelenz March 5, 2025 10:17
@casella casella enabled auto-merge (squash) March 5, 2025 10:18
Copy link
Contributor

@maltelenz maltelenz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As described in my comment this seems good from a "simulate nicely in WSM" standpoint.

I want to make clear that I have no expertise on the model itself or the domain.

@casella
Copy link
Contributor Author

casella commented Mar 5, 2025

I want to make clear that I have no expertise on the model itself or the domain.

Sure. For that, we wait for @AHaumer's or @christiankral's input.

@casella
Copy link
Contributor Author

casella commented Mar 5, 2025

I also have a (slightly rusty by now) degree in Electronic Engineering cum laude 😄

@AHaumer
Copy link
Contributor

AHaumer commented Mar 5, 2025

@casella the whole discussing was a little bit misleading, there are 2 examples of SMPM braking using a rectifier:

  • Modelica.Electrical.Machines.Examples.SynchronousMachines.SMPM_Braking
  • Modelica.Magnetic.FundamentalWave.Examples.BasicMachines.SynchronousMachines.SMPM_Braking
    Should we apply the same solution to the other example, too?

Copy link
Contributor

@AHaumer AHaumer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
but IMHO the same solution should be applied to Modelica.Electrical.Machines.Examples.SynchronousMachines.SMPM_Braking

@casella casella merged commit 1d74ace into modelica:master Mar 5, 2025
2 checks passed
Esther-Devakirubai pushed a commit that referenced this pull request Mar 6, 2025
* Increased Ron and Goff to make the system more numerically robust

* Updated documentation
@Esther-Devakirubai
Copy link
Contributor

Backported by #4570

@casella
Copy link
Contributor Author

casella commented Mar 6, 2025

@casella the whole discussing was a little bit misleading, there are 2 examples of SMPM braking using a rectifier:

* Modelica.Electrical.Machines.Examples.SynchronousMachines.SMPM_Braking
* Modelica.Magnetic.FundamentalWave.Examples.BasicMachines.SynchronousMachines.SMPM_Braking

Good point. I got a regression on the second one, but if the two examples are similar it may make sense to also fix the other one. @maltelenz wrote in another ticket that they also had problems in WSL with the first one, so I'm fine with PR #4563.

In fact, as I discussed here, we could even think of changing the default values for the underlying switching supply models. However, I think it's best to fix the regressions locally in 4.1.0 where they show up, and then consider changing the default in MSL 4.2.0. That requires some analysis of side effects and is not something I'd do in a rush.

@AHaumer do you agree?

@AHaumer
Copy link
Contributor

AHaumer commented Mar 6, 2025

@casella these two examples are pretty much the same except for the machine models which are 100% compatible speaking if connectros and parameters (only the internal representation is different).

AHaumer added a commit that referenced this pull request Mar 6, 2025
Attempt to fix #4559 by increasing RonDiode and GoffDiode (#4562)
@beutlich beutlich removed the request for review from christiankral March 11, 2025 20:19
@beutlich beutlich added this to the maintenance milestone Mar 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

example Issue only addresses example(s) L: Magnetic.FundamentalWave Issue addresses Modelica.Magnetic.FundamentalWave

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Regression: SMPM_Braking in MSL v4.1.0-dev fails due to chattering in OpenModelica

5 participants