-
Notifications
You must be signed in to change notification settings - Fork 176
Apply same patch as #4559 to Electrical.Machines #4563
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
I get significantly different results compared to the (old) reference: |
|
@maltelenz I'll check in the evening. |
|
@AHaumer Apologies, I don't know what I did for the previous comment. I reran the experiment, and everything seems fine now. I must have made some mistake before. So this seems fine for WSM. |
casella
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Let's fix this locally for all models that have some issues at least in one tool. We'll consider changing the default in MSL 4.2.0
|
@maltelenz you have a green light from a library officer (the author of this PR) and from the Master of Ceremonies (yours truly), so I guess if this runs fine in WSL you can safely approve it, so we can merge it in. Thanks! |
|
Backported by #4582 |
Co-authored-by: Anton Haumer <[email protected]>




see discussion in #4559
@Esther-Devakirubai please backport to 4.1.x as sson as merged.
@GallLeo @MatthiasBSchaefer please re-generate referecne results.
Thanks!