Skip to content

Conversation

@AHaumer
Copy link
Contributor

@AHaumer AHaumer commented Mar 5, 2025

see discussion in #4559
@Esther-Devakirubai please backport to 4.1.x as sson as merged.
@GallLeo @MatthiasBSchaefer please re-generate referecne results.
Thanks!

@AHaumer AHaumer added L: Electrical.Machines Issue addresses Modelica.Electrical.Machines example Issue only addresses example(s) labels Mar 5, 2025
@AHaumer AHaumer added this to the MSL4.1.0 milestone Mar 5, 2025
@AHaumer AHaumer self-assigned this Mar 5, 2025
@maltelenz
Copy link
Contributor

I get significantly different results compared to the (old) reference:
image
image
image
image
@AHaumer is this expected with the new parametrization?

@AHaumer
Copy link
Contributor Author

AHaumer commented Mar 5, 2025

@maltelenz I'll check in the evening.
Results of Electrical.Machines and Magnetic.FundamentalWave should be the same (with same parameters).

@maltelenz
Copy link
Contributor

@AHaumer Apologies, I don't know what I did for the previous comment. I reran the experiment, and everything seems fine now. I must have made some mistake before.

So this seems fine for WSM.

Copy link
Contributor

@casella casella left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Let's fix this locally for all models that have some issues at least in one tool. We'll consider changing the default in MSL 4.2.0

@casella
Copy link
Contributor

casella commented Mar 6, 2025

@maltelenz you have a green light from a library officer (the author of this PR) and from the Master of Ceremonies (yours truly), so I guess if this runs fine in WSL you can safely approve it, so we can merge it in. Thanks!

@casella casella merged commit 5a5fb10 into modelica:master Mar 6, 2025
2 checks passed
@Esther-Devakirubai
Copy link
Contributor

Backported by #4582

casella pushed a commit that referenced this pull request Mar 10, 2025
@beutlich beutlich removed the request for review from christiankral March 11, 2025 20:23
@beutlich beutlich modified the milestones: MSL4.1.0, maintenance Mar 11, 2025
@beutlich beutlich changed the title Same patch as #4559 to Electrical.Machines Apply same patch as #4559 to Electrical.Machines Mar 11, 2025
@AHaumer AHaumer deleted the SMPM_Braking branch April 19, 2025 09:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

example Issue only addresses example(s) L: Electrical.Machines Issue addresses Modelica.Electrical.Machines

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants