Skip to content

Attempt to fix #4559 by increasing RonDiode and GoffDiode #4570

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 6, 2025
Merged

Attempt to fix #4559 by increasing RonDiode and GoffDiode #4570

merged 1 commit into from
Mar 6, 2025

Conversation

@Esther-Devakirubai
Copy link
Contributor

@Esther-Devakirubai Esther-Devakirubai commented Mar 6, 2025

Backports #4562

@casella @Esther-Devakirubai
Attempt to fix #4559 by increasing RonDiode and GoffDiode (#4562)
375fcfc 
* Increased Ron and Goff to make the system more numerically robust

* Updated documentation
@Esther-Devakirubai Esther-Devakirubai added L: Magnetic.FundamentalWave Issue addresses Modelica.Magnetic.FundamentalWave example Issue only addresses example(s) labels Mar 6, 2025
@Esther-Devakirubai Esther-Devakirubai added this to the MSL4.1.0 milestone Mar 6, 2025
@Esther-Devakirubai Esther-Devakirubai mentioned this pull request Mar 6, 2025
Merged
AHaumer
AHaumer approved these changes Mar 6, 2025
View reviewed changes
Copy link
Contributor

@AHaumer AHaumer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@AHaumer AHaumer merged commit ddfe123 into maint/4.1.x Mar 6, 2025
2 checks passed
@AHaumer AHaumer deleted the bp_pr4562 branch March 6, 2025 15:19
@MatthiasBSchaefer MatthiasBSchaefer mentioned this pull request Mar 7, 2025
Merged
@casella casella mentioned this pull request Mar 8, 2025
Closed
@beutlich beutlich changed the title Attempt to fix #4559 by increasing RonDiode and GoffDiode (#4562) Attempt to fix #4559 by increasing RonDiode and GoffDiode Mar 11, 2025
@coderabbitai coderabbitai bot mentioned this pull request Apr 16, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@maltelenz maltelenz maltelenz approved these changes

@AHaumer AHaumer AHaumer approved these changes

Assignees

No one assigned

Labels

example Issue only addresses example(s) L: Magnetic.FundamentalWave Issue addresses Modelica.Magnetic.FundamentalWave

Projects

None yet

Milestone

MSL4.1.0

Development

Successfully merging this pull request may close these issues.

5 participants

@Esther-Devakirubai @maltelenz @AHaumer @casella