-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
FIX: ctf data can sometimes have no date time. #10957
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
I would rather set the date to 1) the epoch |
new commit: I had to use a higher date, else there is an error at reading time after saving the ctf as a fif. Thanks Eric. I did not understand option 1), but I agree that option 2) would be best: we don't have a date, so we shouldn't try to force it. However, it will likely require a lot of downstream corrections. I'll be using this branch, as it unblocks my pipeline, but feel free to take over. |
1970/01/01 okay for you @kingjr ? @agramfort @hoechenberger @drammock feel free to merge if happy |
LGTM, thanks Eric! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, just one tiny suggestion to make the logger.info
message clearer.
Co-authored-by: Daniel McCloy <[email protected]>
* upstream/main: FIX: ctf data can sometimes have no date time. (mne-tools#10957) replace check_version from _testing.py with the one in check.py (mne-tools#10958) ENH: mne-tools#10542 Adds __eq__() to DigMontage class and updates tests. (mne-tools#10942) Use HiDPI icons with PyQt5/PySide2 (mne-tools#10956)
I encountered a bug when reading a CTF dataset with an empty string in the
res4['data_date']
andres4['data_time']
fields.This sets the field to January 1st of the year 1001 (earlier make a date parsing bug)