Use HiDPI icons with PyQt5/PySide2 #10956
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cbrnr
force-pushed
the
qt-browser-hidpi-icons
branch
from
e0ac89a to
c1ece3c
Compare
|
Worth a |
|
I think we're good, it's a tiny change. |
|
Hm, now that I've merged, I'm thinking that maybe it would have been better to put the change in |
I think this is the right place -- we have multiple GUIs here that will benefit, too (Brain, coreg, ieeg-gui eventually). Also I'm not too worried about setting this since IIRC |
larsoner
added a commit
to alexrockhill/mne-python
that referenced
this pull request
Jul 27, 2022
* upstream/main: FIX: ctf data can sometimes have no date time. (mne-tools#10957) replace check_version from _testing.py with the one in check.py (mne-tools#10958) ENH: mne-tools#10542 Adds __eq__() to DigMontage class and updates tests. (mne-tools#10942) Use HiDPI icons with PyQt5/PySide2 (mne-tools#10956)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Qt browser backend with PyQt5/PySide2 does not show HiDPI icons, because an attribute needs to be set manually. This does not apply for PySide6/PyQt6, where HiDPI icons are used by default.