Skip to content

fix(apple): reduce build noise from Flipper and dependencies #508

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 20, 2021
Merged

fix(apple): reduce build noise from Flipper and dependencies #508

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions ios/ReactTestApp.xcodeproj/project.pbxproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -223,8 +223,8 @@
19ECD0CA232ED425003D8557 /* Project object */ = {
isa = PBXProject;
attributes = {
LastSwiftUpdateCheck = 1250;
LastUpgradeCheck = 1250;
LastSwiftUpdateCheck = 1300;
LastUpgradeCheck = 1300;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

probably just a nit, but might be worth waiting for this change to land for when Xcode 13.0 comes out? Or write a note somewhere about the fact that we're already using Xcode 13 here?

Or just do nothing, I guess it's mostly just you using this repo anyway 😅

Copy link
Member Author

@tido64 tido64 Sep 20, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These two lines don't really do anything other than letting Xcode know that we've done a code base "upgrade". There were no changes between 12 and 13 in RNTA, so these have no other effect than not prompting users to upgrade when they open a project with Xcode 13.

ORGANIZATIONNAME = Microsoft;
TargetAttributes = {
19ECD0D1232ED425003D8557 = {
Expand Down
5 changes: 5 additions & 0 deletions ios/test_app.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -332,6 +332,11 @@ def use_test_app_internal!(target_platform, options)
config.build_settings.delete('IPHONEOS_DEPLOYMENT_TARGET')
config.build_settings.delete('MACOSX_DEPLOYMENT_TARGET')
end
when /\AFlipper/, 'libevent'
target.build_configurations.each do |config|
# Flipper and its dependencies log too many warnings
config.build_settings['WARNING_CFLAGS'] ||= ['"-w"']
end
when /\AReact/
target.build_configurations.each do |config|
# Xcode 10.2 requires suppression of nullability for React
Expand Down
4 changes: 2 additions & 2 deletions macos/ReactTestApp.xcodeproj/project.pbxproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -214,8 +214,8 @@
193EF057247A736100BE8C79 /* Project object */ = {
isa = PBXProject;
attributes = {
LastSwiftUpdateCheck = 1250;
LastUpgradeCheck = 1250;
LastSwiftUpdateCheck = 1300;
LastUpgradeCheck = 1300;
ORGANIZATIONNAME = Microsoft;
TargetAttributes = {
193EF05E247A736100BE8C79 = {
Expand Down