This repository was archived by the owner on Mar 4, 2020. It is now read-only.
fix(FocusZone) Remove unused prop 'componentRef' #397
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sophieH29
requested review from
dvdzkwsk,
kuzhelov,
levithomason,
miroslavstastny and
mnajdova
as code owners
Codecov Report
@@ Coverage Diff @@
## master #397 +/- ##
=======================================
Coverage 91.72% 91.72%
=======================================
Files 41 41
Lines 1341 1341
Branches 172 197 +25
=======================================
Hits 1230 1230
Misses 107 107
Partials 4 4Continue to review full report at Codecov.
|
kuzhelov
approved these changes
Oct 24, 2018
| @@ -2,7 +2,9 @@ | |||
|
|
|||
| This is a list of changes made to this Stardust copy of FocusZone in comparison with the original [Fabric FocusZone @ 0f567e05952c6b50c691df2fb72d100b5e525d9e](https://github.com/OfficeDev/office-ui-fabric-react/blob/0f567e05952c6b50c691df2fb72d100b5e525d9e/packages/office-ui-fabric-react/src/components/FocusZone/FocusZone.tsx). | |||
|
|
|||
| ### fix(FocusZone)with defaultTabbableElement prop set tabindexes are not updated accordingly [#342](https://github.com/stardust-ui/react/pull/342) | |||
| ### fixes | |||
| - With defaultTabbableElement prop set tabindexes are not updated accordingly ([#342](https://github.com/stardust-ui/react/pull/342)) | |||
There was a problem hiding this comment.
nit: put defaultTabbableElement in quotes, 'tab indexes' should be two words
There was a problem hiding this comment.
will do, thank you
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removed leftover from FocusZone -
componentRef, which is not used as we're settingfocusZoneRefin parentUIComponentduring components rendering.