Skip to content
This repository was archived by the owner on Mar 4, 2020. It is now read-only.

Commit 62dbe10

Browse files
authored
fix(FocusZone) Remove unused prop 'componentRef' (#397)
* Remove unused prop componentRef * Update changelog * small improvement
1 parent 556fef3 commit 62dbe10

File tree

3 files changed

+3
-8
lines changed

3 files changed

+3
-8
lines changed

src/lib/accessibility/FocusZone/CHANGELOG.md

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,9 @@
22

33
This is a list of changes made to this Stardust copy of FocusZone in comparison with the original [Fabric FocusZone @ 0f567e05952c6b50c691df2fb72d100b5e525d9e](https://github.com/OfficeDev/office-ui-fabric-react/blob/0f567e05952c6b50c691df2fb72d100b5e525d9e/packages/office-ui-fabric-react/src/components/FocusZone/FocusZone.tsx).
44

5-
### fix(FocusZone)with defaultTabbableElement prop set tabindexes are not updated accordingly [#342](https://github.com/stardust-ui/react/pull/342)
5+
### fixes
6+
- With `defaultTabbableElement` prop set tab indexes are not updated accordingly ([#342](https://github.com/stardust-ui/react/pull/342))
7+
- Remove unused prop `componentRef` ([#397](https://github.com/stardust-ui/react/pull/397))
68

79
### feat(FocusZone): Add embed mode for FocusZone and new Chat behavior [#233](https://github.com/stardust-ui/react/pull/233)
810
- Replaced `onFocusNotification` with a regular `onFocus` event callback to pass unit tests with embed.

src/lib/accessibility/FocusZone/FocusZone.tsx

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -43,7 +43,6 @@ function getParent(child: HTMLElement): HTMLElement | null {
4343

4444
export class FocusZone extends React.Component<FocusZoneProps> implements IFocusZone {
4545
static propTypes = {
46-
componentRef: PropTypes.object,
4746
className: PropTypes.string,
4847
direction: PropTypes.number,
4948
defaultTabbableElement: PropTypes.string,

src/lib/accessibility/FocusZone/FocusZone.types.ts

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -32,12 +32,6 @@ export interface IFocusZone {
3232
* FocusZone component props.
3333
*/
3434
export interface FocusZoneProps extends React.HTMLAttributes<HTMLElement | FocusZone> {
35-
/**
36-
* Optional callback to access the FocusZone interface. Use this instead of ref for accessing
37-
* the public methods and properties of the component.
38-
*/
39-
componentRef?: React.RefObject<FocusZone>
40-
4135
/**
4236
* Additional class name to provide on the root element, in addition to the ms-FocusZone class.
4337
*/

0 commit comments

Comments
 (0)