Skip to content
This repository was archived by the owner on Mar 4, 2020. It is now read-only.

fix(FocusZone) Remove unused prop 'componentRef' #397

Merged
merged 4 commits into from
Oct 24, 2018
Merged

fix(FocusZone) Remove unused prop 'componentRef' #397

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
823f1b5
Remove unused prop componentRef
Oct 24, 2018
3e615a6
Update changelog
Oct 24, 2018
949e640
Merge branch 'master' into fix/focus-zone-remove-unused-prop
sophieH29 Oct 24, 2018
aacf303
small improvement
Oct 24, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion src/lib/accessibility/FocusZone/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,9 @@

This is a list of changes made to this Stardust copy of FocusZone in comparison with the original [Fabric FocusZone @ 0f567e05952c6b50c691df2fb72d100b5e525d9e](https://github.com/OfficeDev/office-ui-fabric-react/blob/0f567e05952c6b50c691df2fb72d100b5e525d9e/packages/office-ui-fabric-react/src/components/FocusZone/FocusZone.tsx).

### fix(FocusZone)with defaultTabbableElement prop set tabindexes are not updated accordingly [#342](https://github.com/stardust-ui/react/pull/342)
### fixes
- With `defaultTabbableElement` prop set tab indexes are not updated accordingly ([#342](https://github.com/stardust-ui/react/pull/342))
- Remove unused prop `componentRef` ([#397](https://github.com/stardust-ui/react/pull/397))

### feat(FocusZone): Add embed mode for FocusZone and new Chat behavior [#233](https://github.com/stardust-ui/react/pull/233)
- Replaced `onFocusNotification` with a regular `onFocus` event callback to pass unit tests with embed.
Expand Down
1 change: 0 additions & 1 deletion src/lib/accessibility/FocusZone/FocusZone.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,6 @@ function getParent(child: HTMLElement): HTMLElement | null {

export class FocusZone extends React.Component<FocusZoneProps> implements IFocusZone {
static propTypes = {
componentRef: PropTypes.object,
className: PropTypes.string,
direction: PropTypes.number,
defaultTabbableElement: PropTypes.string,
Expand Down
6 changes: 0 additions & 6 deletions src/lib/accessibility/FocusZone/FocusZone.types.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,12 +32,6 @@ export interface IFocusZone {
* FocusZone component props.
*/
export interface FocusZoneProps extends React.HTMLAttributes<HTMLElement | FocusZone> {
/**
* Optional callback to access the FocusZone interface. Use this instead of ref for accessing
* the public methods and properties of the component.
*/
componentRef?: React.RefObject<FocusZone>

/**
* Additional class name to provide on the root element, in addition to the ms-FocusZone class.
*/
Expand Down