-
Notifications
You must be signed in to change notification settings - Fork 12.8k
Use var in Debug namespace #55011
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use var in Debug namespace #55011
Conversation
@typescript-bot perf test this |
Heya @jakebailey, I've started to run the perf test suite on this PR at 030c159. You can monitor the build here. Update: The results are in! |
@jakebailey Here they are:
CompilerComparison Report - main..55011
System
Hosts
Scenarios
TSServerComparison Report - main..55011
System
Hosts
Scenarios
StartupComparison Report - main..55011
System
Hosts
Scenarios
Developer Information: |
well, that's inconclusive |
@typescript-bot new perf test this faster |
Heya @jakebailey, I've started to run the tsc-only perf test suite on this PR at 030c159. You can monitor the build here. Update: The results are in! |
@jakebailey Here they are:
CompilerComparison Report - baseline..pr
System info unknown
Hosts
Scenarios
Developer Information: |
Pulled out of #53228 (which itself was pulled out of #51455).
My end intent is that we move Debug to a module (#51441) which will effectively do this via esbuild, but I'm curious as to the perf benefit of just this one change.