Skip to content

Use var in Debug namespace #55011

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Conversation

jakebailey
Copy link
Member

Pulled out of #53228 (which itself was pulled out of #51455).

My end intent is that we move Debug to a module (#51441) which will effectively do this via esbuild, but I'm curious as to the perf benefit of just this one change.

@typescript-bot typescript-bot added Author: Team For Uncommitted Bug PR for untriaged, rejected, closed or missing bug labels Jul 13, 2023
@jakebailey
Copy link
Member Author

@typescript-bot perf test this

@typescript-bot
Copy link
Collaborator

typescript-bot commented Jul 13, 2023

Heya @jakebailey, I've started to run the perf test suite on this PR at 030c159. You can monitor the build here.

Update: The results are in!

@typescript-bot
Copy link
Collaborator

@jakebailey
The results of the perf run you requested are in!

Here they are:

Compiler

Comparison Report - main..55011
Metric main 55011 Delta Best Worst p-value
Angular - node (v18.10.0, x64)
Memory used 366,867k (± 0.01%) 366,848k (± 0.01%) ~ 366,795k 366,874k p=0.423 n=6
Parse Time 3.38s (± 0.52%) 3.40s (± 0.47%) ~ 3.39s 3.43s p=0.096 n=6
Bind Time 1.12s (± 0.36%) 1.12s (± 0.67%) ~ 1.11s 1.13s p=1.000 n=6
Check Time 8.89s (± 0.47%) 8.87s (± 0.51%) ~ 8.81s 8.93s p=0.419 n=6
Emit Time 7.53s (± 0.43%) 7.53s (± 0.76%) ~ 7.48s 7.64s p=0.747 n=6
Total Time 20.92s (± 0.30%) 20.92s (± 0.44%) ~ 20.85s 21.09s p=0.688 n=6
Compiler-Unions - node (v18.10.0, x64)
Memory used 191,140k (± 0.03%) 193,927k (± 1.62%) ~ 190,993k 196,893k p=0.575 n=6
Parse Time 1.51s (± 0.27%) 1.51s (± 0.97%) ~ 1.49s 1.53s p=0.863 n=6
Bind Time 0.77s (± 0.53%) 0.77s (± 0.82%) ~ 0.76s 0.78s p=0.673 n=6
Check Time 9.54s (± 0.48%) 9.47s (± 1.76%) ~ 9.25s 9.69s p=0.748 n=6
Emit Time 2.76s (± 0.44%) 2.75s (± 1.55%) ~ 2.69s 2.80s p=0.935 n=6
Total Time 14.57s (± 0.32%) 14.50s (± 1.25%) ~ 14.30s 14.74s p=0.873 n=6
Monaco - node (v18.10.0, x64)
Memory used 346,873k (± 0.01%) 346,878k (± 0.01%) ~ 346,840k 346,943k p=0.936 n=6
Parse Time 2.62s (± 0.88%) 2.61s (± 1.07%) ~ 2.58s 2.66s p=0.628 n=6
Bind Time 1.02s (± 0.51%) 1.01s (± 0.88%) ~ 1.00s 1.02s p=0.190 n=6
Check Time 7.26s (± 0.42%) 7.27s (± 0.26%) ~ 7.24s 7.29s p=0.517 n=6
Emit Time 4.22s (± 0.53%) 4.22s (± 0.47%) ~ 4.19s 4.24s p=0.676 n=6
Total Time 15.12s (± 0.42%) 15.11s (± 0.31%) ~ 15.03s 15.17s p=0.871 n=6
TFS - node (v18.10.0, x64)
Memory used 300,891k (± 0.00%) 300,904k (± 0.01%) ~ 300,886k 300,924k p=0.093 n=6
Parse Time 2.08s (± 0.66%) 2.08s (± 0.79%) ~ 2.06s 2.10s p=0.934 n=6
Bind Time 1.13s (± 0.93%) 1.12s (± 0.56%) ~ 1.11s 1.13s p=0.388 n=6
Check Time 6.65s (± 0.66%) 6.66s (± 0.56%) ~ 6.61s 6.70s p=0.807 n=6
Emit Time 3.85s (± 0.81%) 3.85s (± 1.01%) ~ 3.80s 3.90s p=0.809 n=6
Total Time 13.71s (± 0.39%) 13.72s (± 0.52%) ~ 13.62s 13.81s p=1.000 n=6
material-ui - node (v18.10.0, x64)
Memory used 482,384k (± 0.01%) 482,474k (± 0.02%) ~ 482,406k 482,618k p=0.066 n=6
Parse Time 3.05s (± 2.63%) 3.11s (± 1.61%) ~ 3.01s 3.15s p=0.124 n=6
Bind Time 0.97s (± 5.89%) 0.93s (± 5.18%) ~ 0.91s 1.03s p=0.180 n=6
Check Time 17.28s (± 0.61%) 17.35s (± 0.38%) ~ 17.26s 17.41s p=0.378 n=6
Emit Time 0.00s (± 0.00%) 0.00s (± 0.00%) ~ 0.00s 0.00s p=1.000 n=6
Total Time 21.30s (± 0.59%) 21.39s (± 0.34%) ~ 21.28s 21.46s p=0.199 n=6
xstate - node (v18.10.0, x64)
Memory used 563,695k (± 0.02%) 563,711k (± 0.02%) ~ 563,608k 563,862k p=1.000 n=6
Parse Time 3.85s (± 0.64%) 3.85s (± 0.91%) ~ 3.80s 3.88s p=1.000 n=6
Bind Time 1.65s (± 0.50%) 1.65s (± 1.06%) ~ 1.64s 1.68s p=1.000 n=6
Check Time 2.82s (± 1.18%) 2.80s (± 0.69%) ~ 2.77s 2.83s p=0.195 n=6
Emit Time 0.08s (± 0.00%) 0.08s (± 0.00%) ~ 0.08s 0.08s p=1.000 n=6
Total Time 8.41s (± 0.59%) 8.39s (± 0.63%) ~ 8.33s 8.45s p=0.470 n=6
Angular - node (v16.17.1, x64)
Memory used 366,228k (± 0.01%) 366,239k (± 0.01%) ~ 366,217k 366,277k p=0.230 n=6
Parse Time 3.57s (± 0.41%) 3.57s (± 0.23%) ~ 3.56s 3.58s p=0.730 n=6
Bind Time 1.18s (± 0.44%) 1.18s (± 0.46%) ~ 1.18s 1.19s p=0.640 n=6
Check Time 9.66s (± 0.53%) 9.63s (± 0.37%) ~ 9.58s 9.68s p=0.332 n=6
Emit Time 7.98s (± 0.65%) 7.97s (± 0.64%) ~ 7.88s 8.02s p=0.810 n=6
Total Time 22.38s (± 0.38%) 22.36s (± 0.17%) ~ 22.30s 22.40s p=0.810 n=6
Compiler-Unions - node (v16.17.1, x64)
Memory used 192,934k (± 0.02%) 192,928k (± 0.01%) ~ 192,914k 192,955k p=0.520 n=6
Parse Time 1.59s (± 0.66%) 1.59s (± 0.86%) ~ 1.56s 1.60s p=0.343 n=6
Bind Time 0.82s (± 0.50%) 0.83s (± 1.01%) ~ 0.82s 0.84s p=0.527 n=6
Check Time 10.15s (± 0.42%) 10.14s (± 0.70%) ~ 10.02s 10.24s p=1.000 n=6
Emit Time 3.02s (± 0.58%) 3.02s (± 0.88%) ~ 2.98s 3.05s p=1.000 n=6
Total Time 15.58s (± 0.20%) 15.57s (± 0.42%) ~ 15.50s 15.69s p=0.377 n=6
Monaco - node (v16.17.1, x64)
Memory used 346,178k (± 0.00%) 346,191k (± 0.01%) ~ 346,156k 346,215k p=0.297 n=6
Parse Time 2.77s (± 0.68%) 2.77s (± 0.58%) ~ 2.74s 2.79s p=0.803 n=6
Bind Time 1.08s (± 0.76%) 1.07s (± 0.38%) ~ 1.07s 1.08s p=0.248 n=6
Check Time 7.98s (± 0.49%) 8.01s (± 0.60%) ~ 7.96s 8.07s p=0.467 n=6
Emit Time 4.45s (± 0.64%) 4.45s (± 0.78%) ~ 4.41s 4.51s p=0.871 n=6
Total Time 16.28s (± 0.48%) 16.30s (± 0.51%) ~ 16.22s 16.44s p=0.688 n=6
TFS - node (v16.17.1, x64)
Memory used 300,244k (± 0.00%) 300,240k (± 0.01%) ~ 300,213k 300,258k p=0.688 n=6
Parse Time 2.20s (± 0.45%) 2.20s (± 0.63%) ~ 2.17s 2.21s p=0.452 n=6
Bind Time 1.22s (± 1.24%) 1.20s (± 1.01%) -0.02s (- 1.64%) 1.19s 1.22s p=0.030 n=6
Check Time 7.31s (± 0.46%) 7.32s (± 0.35%) ~ 7.28s 7.36s p=0.936 n=6
Emit Time 4.32s (± 0.92%) 4.32s (± 1.06%) ~ 4.27s 4.39s p=1.000 n=6
Total Time 15.05s (± 0.51%) 15.03s (± 0.42%) ~ 14.95s 15.14s p=0.376 n=6
material-ui - node (v16.17.1, x64)
Memory used 481,690k (± 0.02%) 481,746k (± 0.01%) ~ 481,636k 481,829k p=0.336 n=6
Parse Time 3.26s (± 0.50%) 3.28s (± 0.27%) +0.02s (+ 0.72%) 3.27s 3.29s p=0.028 n=6
Bind Time 0.95s (± 0.88%) 0.96s (± 0.78%) ~ 0.95s 0.97s p=0.652 n=6
Check Time 18.30s (± 0.56%) 18.36s (± 1.24%) ~ 18.18s 18.75s p=0.809 n=6
Emit Time 0.00s (± 0.00%) 0.00s (± 0.00%) ~ 0.00s 0.00s p=1.000 n=6
Total Time 22.51s (± 0.51%) 22.59s (± 1.07%) ~ 22.40s 23.01s p=0.688 n=6
xstate - node (v16.17.1, x64)
Memory used 561,248k (± 0.02%) 561,306k (± 0.02%) ~ 561,166k 561,511k p=0.378 n=6
Parse Time 4.01s (± 0.34%) 4.02s (± 0.19%) ~ 4.01s 4.03s p=0.241 n=6
Bind Time 1.73s (± 5.56%) 1.79s (± 0.65%) ~ 1.77s 1.80s p=0.870 n=6
Check Time 3.13s (± 3.38%) 3.06s (± 0.34%) ~ 3.04s 3.07s p=0.167 n=6
Emit Time 0.09s (± 5.53%) 0.10s (± 5.76%) ~ 0.09s 0.10s p=0.640 n=6
Total Time 8.96s (± 0.30%) 8.96s (± 0.19%) ~ 8.93s 8.98s p=1.000 n=6
Angular - node (v14.21.3, x64)
Memory used 360,177k (± 0.01%) 360,173k (± 0.01%) ~ 360,146k 360,204k p=0.936 n=6
Parse Time 3.72s (± 0.53%) 3.73s (± 0.52%) ~ 3.70s 3.76s p=0.806 n=6
Bind Time 1.22s (± 0.62%) 1.22s (± 0.73%) ~ 1.21s 1.23s p=0.798 n=6
Check Time 10.07s (± 0.54%) 10.11s (± 0.23%) ~ 10.08s 10.14s p=0.225 n=6
Emit Time 8.31s (± 0.24%) 8.30s (± 0.26%) ~ 8.28s 8.34s p=0.465 n=6
Total Time 23.32s (± 0.31%) 23.36s (± 0.12%) ~ 23.32s 23.39s p=0.422 n=6
Compiler-Unions - node (v14.21.3, x64)
Memory used 188,178k (± 0.02%) 188,146k (± 0.01%) ~ 188,120k 188,171k p=0.173 n=6
Parse Time 1.61s (± 0.47%) 1.61s (± 0.47%) ~ 1.60s 1.62s p=1.000 n=6
Bind Time 0.84s (± 0.65%) 0.84s (± 0.97%) ~ 0.84s 0.86s p=0.441 n=6
Check Time 10.28s (± 0.69%) 10.26s (± 0.67%) ~ 10.16s 10.33s p=0.747 n=6
Emit Time 3.12s (± 0.78%) 3.13s (± 0.72%) ~ 3.10s 3.16s p=0.465 n=6
Total Time 15.85s (± 0.54%) 15.84s (± 0.50%) ~ 15.74s 15.94s p=0.873 n=6
Monaco - node (v14.21.3, x64)
Memory used 341,169k (± 0.01%) 341,180k (± 0.01%) ~ 341,154k 341,213k p=0.471 n=6
Parse Time 2.81s (± 0.71%) 2.82s (± 0.52%) ~ 2.80s 2.84s p=0.465 n=6
Bind Time 1.10s (± 0.74%) 1.10s (± 0.00%) ~ 1.10s 1.10s p=0.290 n=6
Check Time 8.27s (± 0.39%) 8.29s (± 0.60%) ~ 8.23s 8.38s p=0.618 n=6
Emit Time 4.67s (± 0.66%) 4.68s (± 0.40%) ~ 4.66s 4.71s p=0.293 n=6
Total Time 16.84s (± 0.21%) 16.89s (± 0.33%) ~ 16.82s 16.99s p=0.167 n=6
TFS - node (v14.21.3, x64)
Memory used 295,332k (± 0.00%) 295,345k (± 0.00%) ~ 295,332k 295,366k p=0.109 n=6
Parse Time 2.44s (± 1.09%) 2.44s (± 0.56%) ~ 2.42s 2.46s p=0.625 n=6
Bind Time 1.08s (± 0.70%) 1.07s (± 0.59%) -0.01s (- 1.08%) 1.06s 1.08s p=0.027 n=6
Check Time 7.60s (± 0.51%) 7.61s (± 0.48%) ~ 7.57s 7.67s p=0.628 n=6
Emit Time 4.29s (± 1.18%) 4.29s (± 0.77%) ~ 4.25s 4.33s p=0.688 n=6
Total Time 15.42s (± 0.44%) 15.41s (± 0.28%) ~ 15.35s 15.47s p=0.936 n=6
material-ui - node (v14.21.3, x64)
Memory used 477,172k (± 0.00%) 477,268k (± 0.00%) +96k (+ 0.02%) 477,241k 477,287k p=0.005 n=6
Parse Time 3.32s (± 0.41%) 3.35s (± 0.41%) +0.04s (+ 1.16%) 3.34s 3.37s p=0.005 n=6
Bind Time 0.99s (± 0.76%) 0.99s (± 0.64%) ~ 0.98s 1.00s p=0.718 n=6
Check Time 19.14s (± 0.72%) 19.13s (± 0.32%) ~ 19.05s 19.23s p=0.872 n=6
Emit Time 0.00s (± 0.00%) 0.00s (± 0.00%) ~ 0.00s 0.00s p=1.000 n=6
Total Time 23.44s (± 0.64%) 23.47s (± 0.27%) ~ 23.40s 23.58s p=0.470 n=6
xstate - node (v14.21.3, x64)
Memory used 550,156k (± 0.00%) 550,145k (± 0.01%) ~ 550,095k 550,183k p=0.873 n=6
Parse Time 4.24s (± 0.64%) 4.23s (± 0.43%) ~ 4.21s 4.26s p=0.743 n=6
Bind Time 1.68s (± 0.75%) 1.68s (± 0.53%) ~ 1.67s 1.69s p=0.933 n=6
Check Time 3.12s (± 0.69%) 3.12s (± 0.26%) ~ 3.11s 3.13s p=0.682 n=6
Emit Time 0.09s (± 0.00%) 0.09s (± 0.00%) ~ 0.09s 0.09s p=1.000 n=6
Total Time 9.13s (± 0.24%) 9.12s (± 0.23%) ~ 9.10s 9.16s p=0.288 n=6
System
Machine Namets-ci-ubuntu
Platformlinux 5.4.0-148-generic
Architecturex64
Available Memory16 GB
Available Memory15 GB
CPUs4 × Intel(R) Core(TM) i7-4770 CPU @ 3.40GHz
Hosts
  • node (v18.10.0, x64)
  • node (v16.17.1, x64)
  • node (v14.21.3, x64)
Scenarios
  • Angular - node (v18.10.0, x64)
  • Angular - node (v16.17.1, x64)
  • Angular - node (v14.21.3, x64)
  • Compiler-Unions - node (v18.10.0, x64)
  • Compiler-Unions - node (v16.17.1, x64)
  • Compiler-Unions - node (v14.21.3, x64)
  • Monaco - node (v18.10.0, x64)
  • Monaco - node (v16.17.1, x64)
  • Monaco - node (v14.21.3, x64)
  • TFS - node (v18.10.0, x64)
  • TFS - node (v16.17.1, x64)
  • TFS - node (v14.21.3, x64)
  • material-ui - node (v18.10.0, x64)
  • material-ui - node (v16.17.1, x64)
  • material-ui - node (v14.21.3, x64)
  • xstate - node (v18.10.0, x64)
  • xstate - node (v16.17.1, x64)
  • xstate - node (v14.21.3, x64)
Benchmark Name Iterations
Current 55011 6
Baseline main 6

TSServer

Comparison Report - main..55011
Metric main 55011 Delta Best Worst p-value
Compiler-UnionsTSServer - node (v18.10.0, x64)
Req 1 - updateOpen 2,550ms (± 0.71%) 2,541ms (± 0.35%) ~ 2,535ms 2,554ms p=0.572 n=6
Req 2 - geterr 5,362ms (± 0.73%) 5,370ms (± 0.38%) ~ 5,340ms 5,397ms p=0.810 n=6
Req 3 - references 346ms (± 0.46%) 345ms (± 0.28%) ~ 343ms 346ms p=0.285 n=6
Req 4 - navto 288ms (± 0.29%) 288ms (± 0.44%) ~ 287ms 290ms p=0.530 n=6
Req 5 - completionInfo count 1,356 (± 0.00%) 1,356 (± 0.00%) ~ 1,356 1,356 p=1.000 n=6
Req 5 - completionInfo 75ms (± 0.68%) 75ms (± 1.31%) ~ 74ms 77ms p=0.504 n=6
CompilerTSServer - node (v18.10.0, x64)
Req 1 - updateOpen 2,637ms (± 0.93%) 2,630ms (± 1.15%) ~ 2,596ms 2,672ms p=0.575 n=6
Req 2 - geterr 4,099ms (± 0.51%) 4,099ms (± 0.41%) ~ 4,070ms 4,116ms p=0.810 n=6
Req 3 - references 350ms (± 0.57%) 351ms (± 0.47%) ~ 349ms 353ms p=0.622 n=6
Req 4 - navto 288ms (± 0.19%) 287ms (± 0.56%) ~ 285ms 289ms p=0.675 n=6
Req 5 - completionInfo count 1,518 (± 0.00%) 1,518 (± 0.00%) ~ 1,518 1,518 p=1.000 n=6
Req 5 - completionInfo 81ms (± 3.47%) 79ms (± 2.65%) ~ 77ms 83ms p=0.285 n=6
xstateTSServer - node (v18.10.0, x64)
Req 1 - updateOpen 3,093ms (± 0.53%) 3,097ms (± 0.33%) ~ 3,085ms 3,109ms p=0.574 n=6
Req 2 - geterr 1,600ms (± 0.68%) 1,584ms (± 0.83%) ~ 1,573ms 1,605ms p=0.054 n=6
Req 3 - references 114ms (± 1.55%) 117ms (± 6.47%) ~ 113ms 132ms p=0.549 n=6
Req 4 - navto 370ms (± 0.84%) 370ms (± 0.23%) ~ 369ms 371ms p=1.000 n=6
Req 5 - completionInfo count 2,872 (± 0.00%) 2,872 (± 0.00%) ~ 2,872 2,872 p=1.000 n=6
Req 5 - completionInfo 379ms (± 1.98%) 387ms (± 1.58%) ~ 376ms 394ms p=0.078 n=6
Compiler-UnionsTSServer - node (v16.17.1, x64)
Req 1 - updateOpen 2,651ms (± 0.61%) 2,647ms (± 0.36%) ~ 2,636ms 2,663ms p=0.378 n=6
Req 2 - geterr 5,970ms (± 0.36%) 5,997ms (± 0.37%) ~ 5,969ms 6,023ms p=0.066 n=6
Req 3 - references 355ms (± 1.45%) 351ms (± 1.39%) ~ 346ms 360ms p=0.167 n=6
Req 4 - navto 286ms (± 1.21%) 287ms (± 0.76%) ~ 283ms 289ms p=0.373 n=6
Req 5 - completionInfo count 1,356 (± 0.00%) 1,356 (± 0.00%) ~ 1,356 1,356 p=1.000 n=6
Req 5 - completionInfo 85ms (± 9.22%) 89ms (± 6.88%) ~ 80ms 99ms p=0.372 n=6
CompilerTSServer - node (v16.17.1, x64)
Req 1 - updateOpen 2,816ms (± 0.83%) 2,795ms (± 0.28%) -21ms (- 0.76%) 2,788ms 2,809ms p=0.020 n=6
Req 2 - geterr 4,657ms (± 0.14%) 4,655ms (± 0.18%) ~ 4,644ms 4,666ms p=1.000 n=6
Req 3 - references 364ms (± 0.58%) 363ms (± 0.29%) ~ 361ms 364ms p=0.160 n=6
Req 4 - navto 281ms (± 0.80%) 282ms (± 0.90%) ~ 277ms 284ms p=0.549 n=6
Req 5 - completionInfo count 1,518 (± 0.00%) 1,518 (± 0.00%) ~ 1,518 1,518 p=1.000 n=6
Req 5 - completionInfo 76ms (± 0.99%) 75ms (± 1.00%) ~ 74ms 76ms p=0.062 n=6
xstateTSServer - node (v16.17.1, x64)
Req 1 - updateOpen 3,235ms (± 0.36%) 3,258ms (± 0.14%) +23ms (+ 0.72%) 3,252ms 3,263ms p=0.005 n=6
Req 2 - geterr 1,754ms (± 1.31%) 1,744ms (± 0.62%) ~ 1,731ms 1,756ms p=0.335 n=6
Req 3 - references 126ms (± 6.91%) 125ms (± 6.11%) ~ 121ms 140ms p=0.188 n=6
Req 4 - navto 352ms (± 0.56%) 353ms (± 0.66%) ~ 352ms 358ms p=0.460 n=6
Req 5 - completionInfo count 2,872 (± 0.00%) 2,872 (± 0.00%) ~ 2,872 2,872 p=1.000 n=6
Req 5 - completionInfo 414ms (± 1.65%) 412ms (± 0.80%) ~ 408ms 416ms p=0.873 n=6
Compiler-UnionsTSServer - node (v14.21.3, x64)
Req 1 - updateOpen 2,791ms (± 0.38%) 2,787ms (± 0.65%) ~ 2,770ms 2,818ms p=0.378 n=6
Req 2 - geterr 6,170ms (± 0.48%) 6,169ms (± 0.37%) ~ 6,138ms 6,198ms p=1.000 n=6
Req 3 - references 361ms (± 1.03%) 360ms (± 0.49%) ~ 359ms 363ms p=1.000 n=6
Req 4 - navto 292ms (± 1.34%) 290ms (± 0.26%) ~ 289ms 291ms p=0.103 n=6
Req 5 - completionInfo count 1,356 (± 0.00%) 1,356 (± 0.00%) ~ 1,356 1,356 p=1.000 n=6
Req 5 - completionInfo 109ms (± 3.73%) 112ms (± 0.36%) ~ 111ms 112ms p=0.214 n=6
CompilerTSServer - node (v14.21.3, x64)
Req 1 - updateOpen 2,942ms (± 0.95%) 2,957ms (± 0.18%) ~ 2,951ms 2,966ms p=0.378 n=6
Req 2 - geterr 4,554ms (± 0.39%) 4,542ms (± 0.58%) ~ 4,500ms 4,569ms p=0.575 n=6
Req 3 - references 376ms (± 0.43%) 376ms (± 0.63%) ~ 373ms 378ms p=0.557 n=6
Req 4 - navto 296ms (± 0.35%) 298ms (± 0.25%) +2ms (+ 0.51%) 297ms 299ms p=0.032 n=6
Req 5 - completionInfo count 1,518 (± 0.00%) 1,518 (± 0.00%) ~ 1,518 1,518 p=1.000 n=6
Req 5 - completionInfo 83ms (± 1.67%) 83ms (± 0.90%) ~ 82ms 84ms p=0.453 n=6
xstateTSServer - node (v14.21.3, x64)
Req 1 - updateOpen 3,452ms (± 0.48%) 3,469ms (± 0.64%) ~ 3,433ms 3,491ms p=0.173 n=6
Req 2 - geterr 1,844ms (± 0.58%) 1,850ms (± 0.72%) ~ 1,823ms 1,858ms p=0.121 n=6
Req 3 - references 153ms (± 6.98%) 154ms (± 5.62%) ~ 137ms 160ms p=1.000 n=6
Req 4 - navto 387ms (± 0.72%) 386ms (± 0.48%) ~ 384ms 389ms p=0.369 n=6
Req 5 - completionInfo count 2,872 (± 0.00%) 2,872 (± 0.00%) ~ 2,872 2,872 p=1.000 n=6
Req 5 - completionInfo 436ms (± 1.64%) 438ms (± 1.71%) ~ 424ms 446ms p=0.872 n=6
System
Machine Namets-ci-ubuntu
Platformlinux 5.4.0-148-generic
Architecturex64
Available Memory16 GB
Available Memory15 GB
CPUs4 × Intel(R) Core(TM) i7-4770 CPU @ 3.40GHz
Hosts
  • node (v18.10.0, x64)
  • node (v16.17.1, x64)
  • node (v14.21.3, x64)
Scenarios
  • Compiler-UnionsTSServer - node (v18.10.0, x64)
  • Compiler-UnionsTSServer - node (v16.17.1, x64)
  • Compiler-UnionsTSServer - node (v14.21.3, x64)
  • CompilerTSServer - node (v18.10.0, x64)
  • CompilerTSServer - node (v16.17.1, x64)
  • CompilerTSServer - node (v14.21.3, x64)
  • xstateTSServer - node (v18.10.0, x64)
  • xstateTSServer - node (v16.17.1, x64)
  • xstateTSServer - node (v14.21.3, x64)
Benchmark Name Iterations
Current 55011 6
Baseline main 6

Startup

Comparison Report - main..55011
Metric main 55011 Delta Best Worst p-value
tsc-startup - node (v16.17.1, x64)
Execution time 142.50ms (± 0.18%) 142.63ms (± 0.21%) +0.13ms (+ 0.09%) 141.93ms 147.83ms p=0.000 n=600
tsserver-startup - node (v16.17.1, x64)
Execution time 222.17ms (± 0.21%) 221.76ms (± 0.21%) -0.41ms (- 0.18%) 220.73ms 229.61ms p=0.000 n=600
tsserverlibrary-startup - node (v16.17.1, x64)
Execution time 223.94ms (± 0.26%) 223.39ms (± 0.17%) -0.55ms (- 0.25%) 222.38ms 230.78ms p=0.000 n=600
typescript-startup - node (v16.17.1, x64)
Execution time 205.67ms (± 0.23%) 205.68ms (± 0.20%) ~ 204.51ms 209.77ms p=0.052 n=600
System
Machine Namets-ci-ubuntu
Platformlinux 5.4.0-148-generic
Architecturex64
Available Memory16 GB
Available Memory15 GB
CPUs4 × Intel(R) Core(TM) i7-4770 CPU @ 3.40GHz
Hosts
  • node (v16.17.1, x64)
Scenarios
  • tsc-startup - node (v16.17.1, x64)
  • tsserver-startup - node (v16.17.1, x64)
  • tsserverlibrary-startup - node (v16.17.1, x64)
  • typescript-startup - node (v16.17.1, x64)
Benchmark Name Iterations
Current 55011 6
Baseline main 6

Developer Information:

Download Benchmark

@jakebailey
Copy link
Member Author

well, that's inconclusive

@jakebailey
Copy link
Member Author

@typescript-bot new perf test this faster

@typescript-bot
Copy link
Collaborator

typescript-bot commented Aug 12, 2023

Heya @jakebailey, I've started to run the tsc-only perf test suite on this PR at 030c159. You can monitor the build here.

Update: The results are in!

@typescript-bot
Copy link
Collaborator

@jakebailey
The results of the perf run you requested are in!

Here they are:

Compiler

Comparison Report - baseline..pr
Metric baseline pr Delta Best Worst p-value
Angular - node (v16.17.1, x64)
Memory used 300,325k (± 0.01%) 300,348k (± 0.01%) ~ 300,314k 300,373k p=0.128 n=6
Parse Time 3.03s (± 0.34%) 3.06s (± 0.13%) +0.03s (+ 1.05%) 3.05s 3.06s p=0.003 n=6
Bind Time 0.93s (± 0.00%) 0.93s (± 0.00%) ~ 0.93s 0.93s p=1.000 n=6
Check Time 9.46s (± 0.16%) 9.46s (± 0.19%) ~ 9.44s 9.48s p=0.618 n=6
Emit Time 7.62s (± 0.35%) 7.61s (± 0.29%) ~ 7.58s 7.64s p=0.625 n=6
Total Time 21.04s (± 0.14%) 21.06s (± 0.13%) ~ 21.01s 21.08s p=0.220 n=6
Compiler-Unions - node (v16.17.1, x64)
Memory used 193,825k (± 0.02%) 193,789k (± 0.00%) -36k (- 0.02%) 193,778k 193,799k p=0.008 n=6
Parse Time 1.58s (± 0.93%) 1.57s (± 1.25%) ~ 1.55s 1.59s p=1.000 n=6
Bind Time 0.79s (± 0.00%) 0.79s (± 0.00%) ~ 0.79s 0.79s p=1.000 n=6
Check Time 9.89s (± 0.19%) 9.86s (± 0.31%) -0.04s (- 0.37%) 9.80s 9.88s p=0.024 n=6
Emit Time 2.74s (± 0.15%) 2.74s (± 0.30%) ~ 2.73s 2.75s p=0.285 n=6
Total Time 15.00s (± 0.20%) 14.97s (± 0.32%) ~ 14.87s 15.00s p=0.227 n=6
Monaco - node (v16.17.1, x64)
Memory used 347,055k (± 0.01%) 347,063k (± 0.00%) ~ 347,031k 347,077k p=0.298 n=6
Parse Time 2.69s (± 0.19%) 2.71s (± 0.39%) ~ 2.69s 2.72s p=0.051 n=6
Bind Time 0.99s (± 0.41%) 0.99s (± 0.52%) ~ 0.98s 0.99s p=0.595 n=6
Check Time 7.89s (± 0.37%) 7.90s (± 0.47%) ~ 7.85s 7.95s p=0.466 n=6
Emit Time 4.25s (± 0.19%) 4.28s (± 0.51%) +0.03s (+ 0.78%) 4.24s 4.30s p=0.032 n=6
Total Time 15.82s (± 0.14%) 15.87s (± 0.20%) +0.05s (+ 0.33%) 15.82s 15.90s p=0.029 n=6
TFS - node (v16.17.1, x64)
Memory used 301,119k (± 0.00%) 301,138k (± 0.00%) +18k (+ 0.01%) 301,127k 301,149k p=0.012 n=6
Parse Time 2.18s (± 0.24%) 2.18s (± 0.45%) ~ 2.17s 2.19s p=0.931 n=6
Bind Time 1.11s (± 0.37%) 1.11s (± 0.76%) ~ 1.09s 1.11s p=0.115 n=6
Check Time 7.23s (± 0.31%) 7.23s (± 0.47%) ~ 7.18s 7.28s p=0.935 n=6
Emit Time 3.99s (± 0.41%) 3.98s (± 0.30%) ~ 3.97s 4.00s p=0.621 n=6
Total Time 14.51s (± 0.13%) 14.50s (± 0.21%) ~ 14.46s 14.55s p=0.459 n=6
material-ui - node (v16.17.1, x64)
Memory used 479,413k (± 0.01%) 479,418k (± 0.01%) ~ 479,364k 479,464k p=0.936 n=6
Parse Time 3.15s (± 0.20%) 3.18s (± 0.26%) +0.03s (+ 0.85%) 3.17s 3.19s p=0.004 n=6
Bind Time 0.91s (± 0.00%) 0.91s (± 0.57%) ~ 0.90s 0.91s p=0.174 n=6
Check Time 17.86s (± 0.38%) 17.88s (± 0.54%) ~ 17.72s 18.00s p=0.810 n=6
Emit Time 0.00s (± 0.00%) 0.00s (± 0.00%) ~ 0.00s 0.00s p=1.000 n=6
Total Time 21.91s (± 0.33%) 21.96s (± 0.45%) ~ 21.80s 22.09s p=0.261 n=6
xstate - node (v16.17.1, x64)
Memory used 542,802k (± 0.02%) 542,782k (± 0.02%) ~ 542,666k 543,016k p=0.689 n=6
Parse Time 3.70s (± 0.22%) 3.71s (± 0.28%) +0.02s (+ 0.45%) 3.70s 3.73s p=0.021 n=6
Bind Time 1.42s (± 4.45%) 1.42s (± 4.36%) ~ 1.34s 1.46s p=0.784 n=6
Check Time 3.22s (± 2.75%) 3.22s (± 2.46%) ~ 3.14s 3.32s p=0.809 n=6
Emit Time 0.08s (± 0.00%) 0.08s (± 0.00%) ~ 0.08s 0.08s p=1.000 n=6
Total Time 8.42s (± 0.39%) 8.43s (± 0.35%) ~ 8.38s 8.46s p=0.572 n=6
System info unknown
Hosts
  • node (v16.17.1, x64)
Scenarios
  • Angular - node (v16.17.1, x64)
  • Compiler-Unions - node (v16.17.1, x64)
  • Monaco - node (v16.17.1, x64)
  • TFS - node (v16.17.1, x64)
  • material-ui - node (v16.17.1, x64)
  • xstate - node (v16.17.1, x64)
Benchmark Name Iterations
Current pr 6
Baseline baseline 6

Developer Information:

Download Benchmarks

@jakebailey jakebailey closed this Aug 30, 2023
@jakebailey jakebailey deleted the debug-var branch August 30, 2023 23:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Author: Team For Uncommitted Bug PR for untriaged, rejected, closed or missing bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants