-
Notifications
You must be signed in to change notification settings - Fork 12.8k
Remove Debug namespace runtime modification #53228
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove Debug namespace runtime modification #53228
Conversation
@typescript-bot perf test this |
Heya @jakebailey, I've started to run the perf test suite on this PR at f2c6bb4. You can monitor the build here. Update: The results are in! |
@jakebailey Here they are:
CompilerComparison Report - main..53228
System
Hosts
Scenarios
TSServerComparison Report - main..53228
System
Hosts
Scenarios
StartupComparison Report - main..53228
System
Hosts
Scenarios
Developer Information: |
Uh oh, it's about a percent worse across the board. No thanks. Maybe perf boost of direct usage via scope hoisting offsets this and that explains the lack of any perf change? |
@typescript-bot perf test this |
Heya @jakebailey, I've started to run the perf test suite on this PR at a6bfdaa. You can monitor the build here. Update: The results are in! |
@jakebailey Here they are:
CompilerComparison Report - main..53228
System
Hosts
Scenarios
TSServerComparison Report - main..53228
System
Hosts
Scenarios
StartupComparison Report - main..53228
System
Hosts
Scenarios
Developer Information: |
@typescript-bot perf test this |
Heya @jakebailey, I've started to run the regular perf test suite on this PR at 6518c76. You can monitor the build here. Update: The results are in! |
@jakebailey Here they are:
tscComparison Report - baseline..pr
System info unknown
Hosts
Scenarios
tsserverComparison Report - baseline..pr
System info unknown
Hosts
Scenarios
startupComparison Report - baseline..pr
System info unknown
Hosts
Scenarios
Developer Information: |
@typescript-bot perf test this |
@jakebailey Here they are:
tscComparison Report - baseline..pr
System info unknown
Hosts
Scenarios
tsserverComparison Report - baseline..pr
System info unknown
Hosts
Scenarios
startupComparison Report - baseline..pr
System info unknown
Hosts
Scenarios
Developer Information: |
@typescript-bot perf test this faster |
@jakebailey Here they are:
tscComparison Report - baseline..pr
System info unknown
Hosts
Scenarios
Developer Information: |
Pulling this out of #51455 for a more directed review.
Perf testing #51455 showed that this mechanism doesn't seem to have a measurable performance impact, and if
Debug
is a module, we can't do this sort of thing without a bunch of setters.