Skip to content

Use var in Debug namespace #55011

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Use var in Debug namespace #55011

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 16 additions & 11 deletions src/compiler/debug.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -110,12 +110,22 @@ export interface LoggingHost {

/** @internal */
export namespace Debug {
/* eslint-disable prefer-const */
let currentAssertionLevel = AssertionLevel.None;
export let currentLogLevel = LogLevel.Warning;
export let isDebugging = false;
export let loggingHost: LoggingHost | undefined;
/* eslint-enable prefer-const */
// Why var? It avoids TDZ checks in the runtime which can be costly.
// See: https://github.com/microsoft/TypeScript/issues/52924
// TODO(jakebailey): restore to let/const once Debug is no longer a namespace.
/* eslint-disable no-var */
var currentAssertionLevel = AssertionLevel.None;
export var currentLogLevel = LogLevel.Warning;
export var isDebugging = false;
export var loggingHost: LoggingHost | undefined;

var enumMemberCache = new Map<any, SortedReadonlyArray<[number, string]>>();

var isDebugInfoEnabled = false;

var flowNodeProto: FlowNodeBase | undefined;
var nodeArrayProto: NodeArray<Node> | undefined;
/* eslint-enable no-var */

type AssertionKeys = MatchingKeys<typeof Debug, AnyFunction>;

Expand Down Expand Up @@ -408,7 +418,6 @@ export namespace Debug {
return value.toString();
}

const enumMemberCache = new Map<any, SortedReadonlyArray<[number, string]>>();

function getEnumMembers(enumObject: any) {
// Assuming enum objects do not change at runtime, we can cache the enum members list
Expand Down Expand Up @@ -496,9 +505,7 @@ export namespace Debug {
return formatEnum(facts, (ts as any).TypeFacts, /*isFlags*/ true);
}

let isDebugInfoEnabled = false;

let flowNodeProto: FlowNodeBase | undefined;

function attachFlowNodeDebugInfoWorker(flowNode: FlowNodeBase) {
if (!("__debugFlowFlags" in flowNode)) { // eslint-disable-line local/no-in-operator
Expand Down Expand Up @@ -547,8 +554,6 @@ export namespace Debug {
}
}

let nodeArrayProto: NodeArray<Node> | undefined;

function attachNodeArrayDebugInfoWorker(array: NodeArray<Node>) {
if (!("__tsDebuggerDisplay" in array)) { // eslint-disable-line local/no-in-operator
Object.defineProperties(array, {
Expand Down