Skip to content

Conversation

abhishektrip
Copy link
Contributor

@abhishektrip abhishektrip commented Sep 7, 2018

Description of changes

Fixes buildingsWithUniqueIds setting being applied to streets dataset and filtering out buildings.

QA checklists

  • Add relevant code comments. Every API class and method should have <summary> description as well as description of parameters.
  • Add tests for new/changed/updated classes and methods!!!
  • Check out conventions in CONTRIBUTING.md.
  • Check out conventions in CODING-STYLE.md
  • Update the changelog
  • Update documentation.

Reviewers

Tag your reviewer(s). Choose wisely.
@brnkhy

@abhishektrip abhishektrip requested a review from brnkhy September 7, 2018 22:04
@brnkhy
Copy link
Contributor

brnkhy commented Sep 7, 2018

@atripathi-mb I think there's a small problem with this. I don't understand the editor stuff but any chance this fix depends on that checkbox being rendered? and still fails if I never expanded that part of the editor.
test;
open scene fresh
change location (33.0291963304386,-96.9712043564994)
change ranges (3,3,3,3)
there are 3 big warehouses in one of the tiles.
open vector settings tab (only main tab)
switch to streets
run again, they'll be missing

Copy link
Contributor

@brnkhy brnkhy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested it using the same method I described earlier, looks like it works properly now. looks good to me

@abhishektrip abhishektrip merged commit b63c2cf into develop Sep 9, 2018
@abhishektrip abhishektrip deleted the fix-buildingid-setting branch September 9, 2018 18:46
abhishektrip added a commit that referenced this pull request Sep 13, 2018
* develop:
  Terrain section event refactor apply property changes at end of gui (#1009)
  fix an issue where TerrainFactoryBase didn't respect "none" terrain option (#1006)
  API's for runtime editing.  (#1005)
  Image section event refactor (#1002)
  Fix buildingid setting (#998)
  Map update develop merge fresh (#994)
  Improve query height method (#979)
  Mid floor calculation bug fix (#968)
  Updated changelog version to v1.4.6
  update changelog
  change ElevatedTerrainStrategy and ElevatedTerrainWithSidesStrategy classes to create flat terrain mesh on height data errors
  UWP fixes (and more) (#945)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants