UWP fixes (and more) #945
Merged
UWP fixes (and more) #945
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # sdkproject/Assets/Mapbox/Unity/Utilities/DescriptionAttribute.cs.meta # sdkproject/Assets/Resources.meta # sdkproject/ProjectSettings/EditorBuildSettings.asset # sdkproject/ProjectSettings/ProjectSettings.asset
* develop: (104 commits) Release/v1.4.5 (#974) Removed unused variables and unused conditional statements. Move scene to ReplaceFeatures Folder. Added IconicBuildings scene to build settings. Created prefab of IconicBuildingMap and ReloadMapIconicBuildingCanvas. Set zoom slider to 10 to match zoom level in abstract map. Updated DataExplorer (SnapToTerrain = true) and ZoomableMap (Zoom value = 16); removed editor script. Editor script. Corrected typo in description text. Changed button look to flat. Changed condition logic regarding UI input component reference acquisition. Made _cameraPosition and _cameraRotation private. Hero building showcase scene and UI. Add imagery to interactive scene Corrected changlog hero building quantity. Update changelog. Update prefabs and scenes. Removed Guggenheim museum mesh/prefab due to scaling issues. Removed reference from modifier. Removed Willis tower model/prefab as we are not releasing Chicago assets yet. Add check to avoid errors with Mapbox Streets. Reordered StyleTypes.Color declaration; moved to end of enum. Saved CitySimulator with correct texture setting, Remove warnings. ... # Conflicts: # sdkproject/Assets/Mapbox/Unity/MeshGeneration/LayerVisualizers/LocationPrefabsLayerVisualizer.cs # sdkproject/ProjectSettings/ProjectSettings.asset # sdkproject/ProjectSettings/ProjectVersion.txt
abhishektrip
approved these changes
Sep 6, 2018
abhishektrip
added a commit
that referenced
this pull request
Sep 6, 2018
* develop: Updated changelog version to v1.4.6 update changelog change ElevatedTerrainStrategy and ElevatedTerrainWithSidesStrategy classes to create flat terrain mesh on height data errors UWP fixes (and more) (#945) Release/v1.4.5 (#974) # Conflicts: # sdkproject/ProjectSettings/ProjectSettings.asset
abhishektrip
added a commit
that referenced
this pull request
Sep 13, 2018
* develop: Terrain section event refactor apply property changes at end of gui (#1009) fix an issue where TerrainFactoryBase didn't respect "none" terrain option (#1006) API's for runtime editing. (#1005) Image section event refactor (#1002) Fix buildingid setting (#998) Map update develop merge fresh (#994) Improve query height method (#979) Mid floor calculation bug fix (#968) Updated changelog version to v1.4.6 update changelog change ElevatedTerrainStrategy and ElevatedTerrainWithSidesStrategy classes to create flat terrain mesh on height data errors UWP fixes (and more) (#945)
Closed
|
For Hololens-2 and Mapbox in Unity UWP, try this repo ; |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issues
#734 #889 #875
Fixes in this PR enable
UWPplayer exports (HoloLens, XBox, Windows Phone, Desktop).Notes:
Scripting Runtime Version:.NET 4.xScripting Backend:.NETIL2CPPdoes not work - for UWP builds.This is due to some dynamic features in
Mapbox.Json.TODO:
@atripathi-mb I haven't tested on OSX.
Could you please verify that the assemblies in
sdkproject/Assets/Mapbox/Core/Plugins/Mapbox/vector-tile-cs/sdkproject/Assets/Mapbox/Core/Plugins/ThirdParty/Mapbox.IO.Compression/sdkproject/Assets/Mapbox/Core/Plugins/ThirdParty/Mapbox.Json/have the correct platform set for OSX too?
Description of changes
DescriptionAttributeerrors with UWP buildsMapbox.Utils.PolygonUtils.PointInPolygonto not rely on theclipperinstance which is actually internal tovector-tile-cs.dependenciesfolder for dependencies, uses assemblies insteadvector-tile-csMapbox.IO.CompressionMapbox.Jsonupdate-mapbox-unity-sdk-core.shupdate-mapbox-unity-sdk-core.batUnityPackagerunitypackage.configSharpCompress.dllUnityPackager.exeQA checklists
<summary>description as well as description of parameters.Reviewers
@atripathi-mb