Image section event refactor #1002
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ifiedProperty and Begin/EndChangeCheck to set imageLayerProperties.HasChanged to true. Renamed ImageryLayer.Refresh to UpdateImageryLayer; refactored UpdateImageryLayer to use System.EventHandler arguments.
abhishektrip
suggested changes
Sep 10, 2018
| options.placementOptions.placementStrategy.SetUpPlacement(this); | ||
|
|
||
| _imagery.UpdateLayer += (factory, updateVector) => | ||
| _imagery.UpdateLayer += (object sender, System.EventArgs e)=> |
There was a problem hiding this comment.
can we have a more descriptive variable name instead of e?
| } | ||
|
|
||
| public void Refresh() | ||
| public void UpdateImageryLayer(object sender, System.EventArgs e) |
There was a problem hiding this comment.
Can we rename this to be UpdateLayer or RedrawLayer - so that the signatures for all layer updates are similar.
… to eventArgs; renamed ImageryLayer.UpdateImageryLayer to RedrawLayer.
abhishektrip
approved these changes
Sep 10, 2018
abhishektrip
added a commit
that referenced
this pull request
Sep 10, 2018
…up-image-terrain * commit 'a6783e62a56c65198c92429e2108ec17cc21ed41': Image section event refactor (#1002) # Conflicts: # sdkproject/Assets/Mapbox/Unity/Map/AbstractMap.cs # sdkproject/Assets/Mapbox/Unity/SourceLayers/ImageryLayer.cs
abhishektrip
added a commit
that referenced
this pull request
Sep 13, 2018
* develop: Terrain section event refactor apply property changes at end of gui (#1009) fix an issue where TerrainFactoryBase didn't respect "none" terrain option (#1006) API's for runtime editing. (#1005) Image section event refactor (#1002) Fix buildingid setting (#998) Map update develop merge fresh (#994) Improve query height method (#979) Mid floor calculation bug fix (#968) Updated changelog version to v1.4.6 update changelog change ElevatedTerrainStrategy and ElevatedTerrainWithSidesStrategy classes to create flat terrain mesh on height data errors UWP fixes (and more) (#945)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue
Runtime map updating
Description of changes
Image section now uses System.EventHandler to fire runtime update events.
QA checklists
<summary>description as well as description of parameters.Reviewers
Tag your reviewer(s). Choose wisely.