Skip to content

Conversation

@Den4ik
Copy link
Contributor

@Den4ik Den4ik commented Jun 18, 2019

Description (*)

Component paging settings allow to define pageSize and options via ui component xml. But defined variables are overridden in php and js.

Also removed unused variable from UiComponent generator

Fixed Issues (if relevant)

no related issue

Manual testing scenarios (*)

  1. Create custom listing or edit exists
  2. Add following code for paging configuration
        <paging name="listing_paging">
            <settings>
                <pageSize>30</pageSize>
                <options>
                    <option name="15" xsi:type="array">
                        <item name="label" xsi:type="string">15</item>
                        <item name="value" xsi:type="string">15</item>
                    </option>
                    <option name="30" xsi:type="array">
                        <item name="label" xsi:type="string">30</item>
                        <item name="value" xsi:type="string">30</item>
                    </option>
                    <option name="50" xsi:type="array">
                        <item name="label" xsi:type="string">50</item>
                        <item name="value" xsi:type="string">50</item>
                    </option>
                    <option name="100" xsi:type="array">
                        <item name="label" xsi:type="string">100</item>
                        <item name="value" xsi:type="string">100</item>
                    </option>
                </options>
            </settings>
        </paging>
  1. Clear cache and bookmarks

Expected result

Expected that grid will show 15, 30, 50, 100 in size selector and 30 as default value

Actual result

20, 30, 50, 100, 200 available in size selector with 20 as default value

Questions or comments

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)

@m2-assistant
Copy link

m2-assistant bot commented Jun 18, 2019

Hi @Den4ik. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.3-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@ghost
Copy link

ghost commented Jun 19, 2019

@Den4ik unfortunately, only members of the maintainers team are allowed to add progress related labels to the pull request

@Den4ik Den4ik force-pushed the bug/component-listing-page-size-xml-config branch from eb6b3e8 to b26a8f8 Compare June 19, 2019 10:35
@dmytro-ch dmytro-ch self-requested a review June 19, 2019 10:49
@dmytro-ch dmytro-ch self-assigned this Jun 19, 2019
@magento-engcom-team
Copy link
Contributor

Hi @dmytro-ch, thank you for the review.
ENGCOM-5310 has been created to process this Pull Request
✳️ @dmytro-ch, could you please add one of the following labels to the Pull Request?

Label Description
Auto-Tests: Covered All changes in Pull Request is covered by auto-tests
Auto-Tests: Not Covered Changes in Pull Request requires coverage by auto-tests
Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests

@dmytro-ch dmytro-ch added the Auto-Tests: Covered All changes in Pull Request is covered by auto-tests label Jun 19, 2019
@engcom-Alfa engcom-Alfa self-assigned this Jun 19, 2019
@engcom-Alfa
Copy link
Contributor

✔️ QA Passed

Before:

before

After:

after

@ghost ghost added the Progress: accept label Jun 20, 2019
@magento-engcom-team magento-engcom-team merged commit b26a8f8 into magento:2.3-develop Jun 21, 2019
@m2-assistant
Copy link

m2-assistant bot commented Jun 21, 2019

Hi @Den4ik, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

taskula pushed a commit to Hypernova-Oy/magento2 that referenced this pull request Jun 21, 2019
@magento-engcom-team magento-engcom-team added this to the Release: 2.3.3 milestone Jun 21, 2019
@Den4ik Den4ik deleted the bug/component-listing-page-size-xml-config branch June 21, 2019 05:25
magento-engcom-team added a commit that referenced this pull request Jun 26, 2019
…ion via ui component xml #23375

 - Merge Pull Request #23375 from magenius-team/magento2:back-port-pull-23307
 - Merged commits:
   1. 54c0f4e
magento-engcom-team pushed a commit that referenced this pull request Jun 26, 2019
magento-engcom-team added a commit that referenced this pull request Jun 26, 2019
Accepted Community Pull Requests:
 - #23332: [Backport] Fixed #23238 Apply button act like remove button while create new order from admin (by @krishprakash)
 - #23331: [Backport] Fixed issue #18337 (by @amol2jcommerce)
 - #23375: [Backport for #23307] Allow to define listing configuration via ui component xml (by @Den4ik)
 - #23152: [Backport] Remove timestap from current date when saving product special price from date (by @krishprakash)
 - #23352: [Backport] fixed issue #22736 - Cursor position not in right side of search keyword in mobile (by @krishprakash)
 - #23149: [Backport] Fixed issue #22767: Not clear logic for loading CMS Pages with setStoreId function (by @krishprakash)
 - #23150: [Backport] Issue fixed #22636 arrow toggle not changing only showing to down It should be toggle as every where is working  (by @krishprakash)


Fixed GitHub Issues:
 - #23238: Apply coupon button act like remove coupon while create new order from admin (reported by @renard123) has been fixed in #23332 by @krishprakash in 2.2-develop branch
   Related commits:
     1. a9406b5
     2. aa49728
     3. 2ca4dbe

 - #18337: #search input is missing required attribute aria-expanded. (reported by @BezV8) has been fixed in #23331 by @amol2jcommerce in 2.2-develop branch
   Related commits:
     1. 83a9c9b
     2. 39e7c2c
     3. 3d989c6

 - #22736: Cursor position not in right side of search keyword in search box when click on search again (Mobile issue) (reported by @bhavik43) has been fixed in #23352 by @krishprakash in 2.2-develop branch
   Related commits:
     1. c068886
     2. 525396a
     3. e7c33f3
     4. 2464b31

 - #22767: Not clear logic for loading CMS Pages with setStoreId function  (reported by @Sharkozp) has been fixed in #23149 by @krishprakash in 2.2-develop branch
   Related commits:
     1. 70d0992
     2. 70aacf1

 - #22636: arrow toggle not changing only showing to down It should be toggle as every where is working  (reported by @cedarvinda) has been fixed in #23150 by @krishprakash in 2.2-develop branch
   Related commits:
     1. f1e8d05
     2. f4653b1
     3. eff816e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants