-
Notifications
You must be signed in to change notification settings - Fork 9.4k
[Ui] Allow to define listing configuration via ui component xml #23307
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Ui] Allow to define listing configuration via ui component xml #23307
Conversation
|
Hi @Den4ik. Thank you for your contribution
For more details, please, review the Magento Contributor Assistant documentation |
4c648d0 to
eb6b3e8
Compare
|
@Den4ik unfortunately, only members of the maintainers team are allowed to add progress related labels to the pull request |
eb6b3e8 to
b26a8f8
Compare
|
Hi @dmytro-ch, thank you for the review.
|
|
Hi @Den4ik, thank you for your contribution! |
…ion via ui component xml #23375
Accepted Community Pull Requests: - #23332: [Backport] Fixed #23238 Apply button act like remove button while create new order from admin (by @krishprakash) - #23331: [Backport] Fixed issue #18337 (by @amol2jcommerce) - #23375: [Backport for #23307] Allow to define listing configuration via ui component xml (by @Den4ik) - #23152: [Backport] Remove timestap from current date when saving product special price from date (by @krishprakash) - #23352: [Backport] fixed issue #22736 - Cursor position not in right side of search keyword in mobile (by @krishprakash) - #23149: [Backport] Fixed issue #22767: Not clear logic for loading CMS Pages with setStoreId function (by @krishprakash) - #23150: [Backport] Issue fixed #22636 arrow toggle not changing only showing to down It should be toggle as every where is working (by @krishprakash) Fixed GitHub Issues: - #23238: Apply coupon button act like remove coupon while create new order from admin (reported by @renard123) has been fixed in #23332 by @krishprakash in 2.2-develop branch Related commits: 1. a9406b5 2. aa49728 3. 2ca4dbe - #18337: #search input is missing required attribute aria-expanded. (reported by @BezV8) has been fixed in #23331 by @amol2jcommerce in 2.2-develop branch Related commits: 1. 83a9c9b 2. 39e7c2c 3. 3d989c6 - #22736: Cursor position not in right side of search keyword in search box when click on search again (Mobile issue) (reported by @bhavik43) has been fixed in #23352 by @krishprakash in 2.2-develop branch Related commits: 1. c068886 2. 525396a 3. e7c33f3 4. 2464b31 - #22767: Not clear logic for loading CMS Pages with setStoreId function (reported by @Sharkozp) has been fixed in #23149 by @krishprakash in 2.2-develop branch Related commits: 1. 70d0992 2. 70aacf1 - #22636: arrow toggle not changing only showing to down It should be toggle as every where is working (reported by @cedarvinda) has been fixed in #23150 by @krishprakash in 2.2-develop branch Related commits: 1. f1e8d05 2. f4653b1 3. eff816e


Description (*)
Component paging settings allow to define pageSize and options via ui component xml. But defined variables are overridden in php and js.
Also removed unused variable from UiComponent generator
Fixed Issues (if relevant)
no related issue
Manual testing scenarios (*)
Expected result
Expected that grid will show 15, 30, 50, 100 in size selector and 30 as default value
Actual result
20, 30, 50, 100, 200 available in size selector with 20 as default value
Questions or comments
Contribution checklist (*)