Not clear logic for loading CMS Pages with setStoreId function

[Sharkozp]

Preconditions (*)

1. 2.1.x
2. 2.2.x
3. 2.3.x

Steps to reproduce (*)

1. Create some class that will load CMS Page:

 /**
     * Constructor.
     */
    public function __construct(
        \Magento\Cms\Model\PageFactory $pageFactory
    ) {
        $this->pageFactory = $pageFactory;
    }

/** @var \Magento\Cms\Model\Page $page */
$page = $this->pageFactory->create();
$page->setStoreId([2]);
$page->load($identifier, Page::IDENTIFIER);

2. According to description for magic function setStoreId must be array in Magento\Cms\Model\Page:
   * @method Page setStoreId(array $storeId)

Link

3. But in Magento\Cms\Model\ResourceModel\Page in method _getLoadSelect you have this part of code:

 if ($object->getStoreId()) {
            $storeIds = [
                Store::DEFAULT_STORE_ID,
                (int)$object->getStoreId(),
            ];
......
}

Link

4. If you will provide array it will be just 1 and not merged with provided array.

Expected result (*)

1. If description correct and store_id must be array, then in Resource Model must be changed logic for merging array
2. If it must be just int, then it must be changed description for magic function in Magento\Cms\Model\Page

Actual result (*)

1. See steps

[m2-assistant]

Hi @Sharkozp. Thank you for your report.
To help us process this issue please make sure that you provided the following information:

• Summary of the issue
• Information on your environment
• Steps to reproduce
• Expected and actual results

Please make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, please, add a comment to the issue:

@magento-engcom-team give me 2.3-develop instance - upcoming 2.3.x release

For more details, please, review the Magento Contributor Assistant documentation.

@Sharkozp do you confirm that you was able to reproduce the issue on vanilla Magento instance following steps to reproduce?

• yes
• no

[m2-assistant]

Hi @GovindaSharma. Thank you for working on this issue.
In order to make sure that issue has enough information and ready for development, please read and check the following instruction: 👇

• 1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).

  Details

  If the issue has a valid description, the label Issue: Format is valid will be added to the issue automatically. Please, edit issue description if needed, until label Issue: Format is valid appears.

• 2. Verify that issue has a meaningful description and provides enough information to reproduce the issue. If the report is valid, add Issue: Clear Description label to the issue by yourself.

• 3. Add Component: XXXXX label(s) to the ticket, indicating the components it may be related to.

• 4. Verify that the issue is reproducible on 2.3-develop branch

  Details

  - Add the comment @magento-engcom-team give me 2.3-develop instance to deploy test instance on Magento infrastructure.
  - If the issue is reproducible on 2.3-develop branch, please, add the label Reproduced on 2.3.x.
  - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!

• 5. Verify that the issue is reproducible on 2.2-develop branch.
  Details

  - Add the comment @magento-engcom-team give me 2.2-develop instance to deploy test instance on Magento infrastructure.
  - If the issue is reproducible on 2.2-develop branch, please add the label Reproduced on 2.2.x

[GovindaSharma]

@Sharkozp thanks for reporting this issue.It's look like its description should be updated because setStoreId is referring to single store ,if it is for multiple stores then method should be updates like setStoreIds .So accordingly description should be updated.

[magento-engcom-team]

✅ Confirmed by @GovindaSharma
Thank you for verifying the issue! 👍 Your confirmation will help us to acknowledge and process this report.

[Sharkozp]

@GovindaSharma and @magento-engcom-team ,

Yes, I also think so. For array it must be method setStoreIds, but I think it was added array for getting more than 1 page, because in _getLoadSelect store ids added via join and used for filters:
->where('cps.store_id IN (?)', $store);

Link

[mahesh-rajawat]

i am working on this.