Skip to content

Conversation

@krishprakash
Copy link

@krishprakash krishprakash commented Jun 6, 2019

Original Pull Request

#22644
Issue fixed #22636

Description (*)

arrow toggle not changing only showing to down It should be toggle as every where is working

Manual testing scenarios (*)

  1. Login to admin panel
  2. Go to store link and click on Tax Rules Available on sub menu
  3. Click on add new tax rule and see Additional Settings tab and click on same

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@m2-assistant
Copy link

m2-assistant bot commented Jun 6, 2019

Hi @krishprakash. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.2-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@krishprakash
Copy link
Author

@magento give me test instance

@magento-engcom-team
Copy link
Contributor

Hi @krishprakash. Thank you for your request. I'm working on Magento instance for you

@magento-engcom-team
Copy link
Contributor

Hi @krishprakash, here is your new Magento instance.
Admin access: https://pr-23150.instances.magento-community.engineering/admin
Login: admin Password: 123123q

@krishprakash
Copy link
Author

krishprakash commented Jun 6, 2019

Fixed issue in given instance.

@magento-engcom-team
Copy link
Contributor

Hi @ronak2ram, thank you for the review.
ENGCOM-5213 has been created to process this Pull Request

@soleksii
Copy link

soleksii commented Jun 6, 2019

✔️ QA Passed

Copy link
Contributor

@orlangur orlangur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@krishprakash original commit author and message must be preserved

@ghost ghost assigned orlangur Jun 6, 2019
@krishprakash krishprakash force-pushed the 2.2-develop-PR-port-22644 branch from b9ed157 to eff816e Compare June 7, 2019 11:13
@magento-cicd2
Copy link
Contributor

CLA assistant check
Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.


Prakash Prajapati seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.

@krishprakash
Copy link
Author

@orlangur I have updated the PR as suggested by you.
Please have a look and update the PR.
Thank you.

@ghost
Copy link

ghost commented Jun 10, 2019

@krishprakash unfortunately, only members of the maintainers team are allowed to remove progress related labels to the pull request

@krishprakash
Copy link
Author

krishprakash commented Jun 13, 2019

@orlangur
Is there anything remaining from my end ?
If any please let me know.
Otherwise please update the status of PR.
Thanks.

@ghost
Copy link

ghost commented Jun 19, 2019

@magento-cicd2 unfortunately, only members of the maintainers team are allowed to unassign developers from the pull request

@magento-engcom-team
Copy link
Contributor

Hi @orlangur, thank you for the review.
ENGCOM-5213 has been created to process this Pull Request
✳️ @orlangur, could you please add one of the following labels to the Pull Request?

Label Description
Auto-Tests: Covered All changes in Pull Request is covered by auto-tests
Auto-Tests: Not Covered Changes in Pull Request requires coverage by auto-tests
Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests

@orlangur orlangur added the Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests label Jun 22, 2019
@engcom-Delta engcom-Delta self-assigned this Jun 24, 2019
@engcom-Delta
Copy link
Contributor

✔️ QA Passed

@m2-assistant
Copy link

m2-assistant bot commented Jun 26, 2019

Hi @krishprakash, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

magento-engcom-team pushed a commit that referenced this pull request Jun 26, 2019
…only showing to down It should be toggle as every where is working #23150
@magento-engcom-team magento-engcom-team added this to the Release: 2.2.10 milestone Jun 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Area: Design/Frontend Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests Partner: Krish TechnoLabs partners-contribution Pull Request is created by Magento Partner Progress: accept Release Line: 2.2

Projects

None yet

Development

Successfully merging this pull request may close these issues.