Skip to content

Conversation

@ArjenMiedema
Copy link

@ArjenMiedema ArjenMiedema commented Jun 12, 2019

Description (*)

When the user isn't logged in and presses the product alert link
(either stock or price), the user has to login and gets redirected
to a 404 page. This is because the redirect done by the login page
is a GET call. The fix done is to change the used interface for
the product alerts from POST to GET, as this is the easy fix and
there's no reason to use POST here at this moment, as all parameters
for the call are all in get URL parameters.

Fixed Issues (if relevant)

  1. Product Alert after login shows 404 page #22266: Product Alert after login shows 404 page

Manual testing scenarios (*)

  1. Create a product in the Magento backend and ensure it's not in stock
  2. Make sure you enable stock and/or price alerts in the configuration and clean the config and full page cache
  3. Go to the frontend of the webshop and ensure you're not logged in
  4. Go to the newly created product
  5. Click the stock alert link and/or the price alert link
  6. Login or create an account here
  7. Ensure the product is added to the stock/price alerts of the current customer account

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)

@m2-assistant
Copy link

m2-assistant bot commented Jun 12, 2019

Hi @ArjenMiedema. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.3-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@magento-cicd2
Copy link
Contributor

magento-cicd2 commented Jun 12, 2019

CLA assistant check
All committers have signed the CLA.

@magento-engcom-team magento-engcom-team added Area: Frontend Component: ProductAlert Release Line: 2.3 Partner: MediaCT Pull Request is created by partner MediaCT partners-contribution Pull Request is created by Magento Partner labels Jun 12, 2019
@ArjenMiedema ArjenMiedema force-pushed the bugfix/22266-fix-404-for-product-alerts branch from 148ea89 to d44970f Compare June 12, 2019 07:51
When the user isn't logged in and presses the product alert link
(either stock or price), the user has to login and gets redirected
to a 404 page. This is because the redirect done by the login page
is a `GET` call. The fix done is to change the used interface for
the product alerts from `POST` to `GET`, as this is the easy fix and
there's no reason to use `POST` here at this moment, as all parameters
for the call are all in get URL parameters.
@ArjenMiedema ArjenMiedema force-pushed the bugfix/22266-fix-404-for-product-alerts branch from d44970f to 361965b Compare June 12, 2019 09:28
@dmytro-ch dmytro-ch self-requested a review June 12, 2019 11:05
@dmytro-ch dmytro-ch self-assigned this Jun 12, 2019
@magento-engcom-team
Copy link
Contributor

Hi @dmytro-ch, thank you for the review.
ENGCOM-5267 has been created to process this Pull Request

@makkoff
Copy link

makkoff commented Jun 12, 2019

✔️ QA Passed

@ghost
Copy link

ghost commented Jun 19, 2019

@magento-cicd2 unfortunately, only members of the maintainers team are allowed to unassign developers from the pull request

@m2-assistant
Copy link

m2-assistant bot commented Jun 26, 2019

Hi @ArjenMiedema, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@magento-engcom-team magento-engcom-team added this to the Release: 2.3.3 milestone Jun 26, 2019
@sidolov sidolov added the Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests label Sep 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Area: Frontend Auto-Tests: Not Required Changes in Pull Request does not require coverage by auto-tests Award: bug fix Component: ProductAlert Partner: MediaCT Pull Request is created by partner MediaCT partners-contribution Pull Request is created by Magento Partner Progress: accept Release Line: 2.3

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants