-
Notifications
You must be signed in to change notification settings - Fork 9.4k
Fixed #22266: 404 message for product alerts when not logged in #23218
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed #22266: 404 message for product alerts when not logged in #23218
Conversation
|
Hi @ArjenMiedema. Thank you for your contribution
For more details, please, review the Magento Contributor Assistant documentation |
148ea89 to
d44970f
Compare
When the user isn't logged in and presses the product alert link (either stock or price), the user has to login and gets redirected to a 404 page. This is because the redirect done by the login page is a `GET` call. The fix done is to change the used interface for the product alerts from `POST` to `GET`, as this is the easy fix and there's no reason to use `POST` here at this moment, as all parameters for the call are all in get URL parameters.
d44970f to
361965b
Compare
|
Hi @dmytro-ch, thank you for the review. |
|
✔️ QA Passed |
|
@magento-cicd2 unfortunately, only members of the maintainers team are allowed to unassign developers from the pull request |
|
Hi @ArjenMiedema, thank you for your contribution! |
Description (*)
When the user isn't logged in and presses the product alert link
(either stock or price), the user has to login and gets redirected
to a 404 page. This is because the redirect done by the login page
is a
GETcall. The fix done is to change the used interface forthe product alerts from
POSTtoGET, as this is the easy fix andthere's no reason to use
POSThere at this moment, as all parametersfor the call are all in get URL parameters.
Fixed Issues (if relevant)
Manual testing scenarios (*)
Contribution checklist (*)