-
Notifications
You must be signed in to change notification settings - Fork 9.4k
#22266 Allow GET method for products alerts #22284
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Hi @ilnytskyi. Thank you for your contribution
For more details, please, review the Magento Contributor Assistant documentation |
999d736 to
0d2b291
Compare
orlangur
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ilnytskyi GET must be implemented as separate action I believe.
Cc: @nmalevanec
|
@orlangur |
|
Closed since similar changes were implemented in #23218 by @ArjenMiedema |
|
Hi @ilnytskyi, thank you for your contribution! |
|
FYI as of 2.3.5 it still gives 404 - unless you either add both of those interfaces, ass suggested by this PR (or, alternatively, remove them completely), tested this myself + here's a testimonial from stackoverlow: |
Description (*)
The classes
\Magento\ProductAlert\Controller\Add\Stock\Magento\ProductAlert\Controller\Add\PriceHas been marked with
\Magento\Framework\App\Action\HttpPostActionInterfacethat caused 404 page issue after a redirect in
\Magento\Customer\Controller\Account\LoginPostFixed Issues (if relevant)
Manual testing scenarios (*)
Contribution checklist (*)