Skip to content

Fixed #22266: 404 message for product alerts when not logged in #23218

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
magento-engcom-team merged 1 commit into from
Jun 26, 2019
Merged

Fixed #22266: 404 message for product alerts when not logged in #23218

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions app/code/Magento/ProductAlert/Controller/Add/Price.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@

namespace Magento\ProductAlert\Controller\Add;

use Magento\Framework\App\Action\HttpPostActionInterface;
use Magento\Framework\App\Action\HttpGetActionInterface;
use Magento\ProductAlert\Controller\Add as AddController;
use Magento\Framework\App\Action\Context;
use Magento\Customer\Model\Session as CustomerSession;
Expand All @@ -20,7 +20,7 @@
/**
* Controller for notifying about price.
*/
class Price extends AddController implements HttpPostActionInterface
class Price extends AddController implements HttpGetActionInterface
{
/**
* @var \Magento\Store\Model\StoreManagerInterface
Expand Down
4 changes: 2 additions & 2 deletions app/code/Magento/ProductAlert/Controller/Add/Stock.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@

namespace Magento\ProductAlert\Controller\Add;

use Magento\Framework\App\Action\HttpPostActionInterface;
use Magento\Framework\App\Action\HttpGetActionInterface;
use Magento\ProductAlert\Controller\Add as AddController;
use Magento\Framework\App\Action\Context;
use Magento\Customer\Model\Session as CustomerSession;
Expand All @@ -19,7 +19,7 @@
/**
* Controller for notifying about stock.
*/
class Stock extends AddController implements HttpPostActionInterface
class Stock extends AddController implements HttpGetActionInterface
{
/**
* @var \Magento\Catalog\Api\ProductRepositoryInterface
Expand Down
2 changes: 1 addition & 1 deletion app/code/Magento/ProductAlert/view/frontend/templates/product/view.phtml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
?>
<?php /* @var $block \Magento\ProductAlert\Block\Product\View */?>
<div class="product alert <?= $block->getHtmlClass() ?>">
<a href="#" data-post='<?= /* @noEscape */ $block->getPostAction() ?>'
<a href="<?= $block->escapeUrl($block->getSignupUrl()) ?>"
title="<?= $block->escapeHtml(__($block->getSignupLabel())) ?>" class="action alert">
<?= $block->escapeHtml(__($block->getSignupLabel())) ?>
</a>
Expand Down