Skip to content

Conversation

@chriszupan
Copy link

Description

Fixed Issues (if relevant)

  1. 2.2.6 Product Attributes (dropdown/multi-select) issue with ampersands #18263
  2. ...

Manual testing scenarios

  1. ...
  2. ...

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@magento-cicd2
Copy link
Contributor

CLA assistant check
Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.

@magento-engcom-team
Copy link
Contributor

Hi @chriszupan. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me $VERSION instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@slavvka
Copy link
Member

slavvka commented Sep 27, 2018

Hey @chriszupan. Thank you for your contribution but we already have internal ticket (MAGETWO-94962) which is in progress currently and will be delivered soon. Additionally I would like to pay your attention that your fix isn't reliable. You fix there consequence of the problem whereas the root cause is in places where serialized_options is formed. It is in app/code/Magento/Catalog/view/adminhtml/web/js/options.js and app/code/Magento/Swatches/view/adminhtml/web/js/product-attributes.js. Also there is another class where the same parse of serialized_options takes place in EE code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants