Skip to content

Conversation

@mage2pratik
Copy link
Contributor

Original Pull Request

#18354

Description

After updating Magento to 2.2.6 when attribute is saved, and option label contains & label is cut before &. It is caused by usage of function parse_str() which is confused by &

Fixed Issues (if relevant)

Manual testing scenarios

  1. Add attribute option with label containing char &
  2. Save attribute
  3. Check if label wa correctly saved.

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@josefbehr
Copy link
Contributor

@mage2pratik Thanks for the contribution. Please fix the failing tests and consider renaming the variable to something a bit shorter (or just replace the $serializedValue).

@josefbehr josefbehr self-assigned this Oct 6, 2018
@josefbehr
Copy link
Contributor

josefbehr commented Oct 8, 2018

@mage2pratik Sorry, but I have to close this PR, as there already exists an internal ticket to fix the issue (see #18293 (comment))

edit: Actually, let me check to be sure

@josefbehr josefbehr closed this Oct 8, 2018
@josefbehr josefbehr added duplicate Progress: reject Fixed in 2.3.x The issue has been fixed in 2.3 release line labels Oct 8, 2018
@josefbehr josefbehr reopened this Oct 8, 2018
@josefbehr josefbehr added Progress: on hold and removed Fixed in 2.3.x The issue has been fixed in 2.3 release line Progress: reject duplicate labels Oct 8, 2018
@josefbehr
Copy link
Contributor

Just confirmed that this is already fixed in 2.3

@josefbehr josefbehr closed this Oct 8, 2018
@josefbehr josefbehr added Fixed in 2.3.x The issue has been fixed in 2.3 release line Progress: reject labels Oct 8, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants