Skip to content

Conversation

@mahesh-rajawat
Copy link
Member

@mahesh-rajawat mahesh-rajawat commented Oct 15, 2018

Description (*)

Saving product attribute dropdown option value with "+" and "&" character was replacing with Space,
this issue is fixed in this pull request.

Fixed Issues (if relevant)

  1. 2.2.6 Product Attributes (dropdown/multi-select) issue with ampersands #18263
  2. Plus char is replaced by space in product attribute dropdown value #18493

Manual testing scenarios (*)

  1. Created a Attribute type drop down and saved value contains '+' character, its not replacing
  2. Created a Attribute type drop down and saved value contains '&' character, its not replacing

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@magento-engcom-team
Copy link
Contributor

Hi @maheshWebkul721. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me $VERSION instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@mahesh-rajawat
Copy link
Member Author

#SQUASHTOBERFEST

@slavvka slavvka self-assigned this Oct 16, 2018
@slavvka
Copy link
Member

slavvka commented Oct 16, 2018

hey @maheshWebkul721 Thank you fo the contribution but such a solution is not reliable. Please look at the comment #18293 (comment) for 2.3. There's also the internal backport ticket for 2.2 (MAGETWO-95426)

@slavvka slavvka closed this Oct 16, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants