Skip to content

Deprecated Magento\Store\Model\Store::$_isAdminSecure #10877

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 14, 2017
Merged

Deprecated Magento\Store\Model\Store::$_isAdminSecure #10877

merged 1 commit into from
Sep 14, 2017

Conversation

@4quaternion
Copy link
Contributor

@4quaternion 4quaternion commented Sep 13, 2017 •
edited by ishakhsuvarov
Loading

Description

Fixed Issues (if relevant)

  1. isAdminSecure never used or missing code #4720: isAdminSecure never used or missing code

Manual testing scenarios

N/A

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@4quaternion
Deprecated Magento\Store\Model\Store::$_isAdminSecure
4bed591 
 - added @depreated tag to unused protected property
 - closing #4720
@magento-engcom-team magento-engcom-team mentioned this pull request Sep 13, 2017
Closed
@ishakhsuvarov ishakhsuvarov self-assigned this Sep 14, 2017
@ishakhsuvarov ishakhsuvarov added this to the September 2017 milestone Sep 14, 2017
@magento-team magento-team merged commit 4bed591 into magento:develop Sep 14, 2017
magento-team pushed a commit that referenced this pull request Sep 14, 2017
@ishakhsuvarov
MAGETWO-75114: Deprecated Magento\Store\Model\Store::$_isAdminSecure #…
0d62224 
…10877
magento-team pushed a commit that referenced this pull request Sep 14, 2017
@ishakhsuvarov
Merge pull request #1493 from magento-engcom/develop-prs
659a245 
[EngCom] Public Pull Requests
 - MAGETWO-75114: Deprecated Magento\Store\Model\Store::$_isAdminSecure #10877
 - MAGETWO-72539: cviking26_issue-9489 // added query param to url build - description … #10848
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@ishakhsuvarov ishakhsuvarov

Labels

Progress: accept

Projects

None yet

Milestone

September 2017

Development

Successfully merging this pull request may close these issues.

3 participants

@4quaternion @magento-team @ishakhsuvarov