-
Notifications
You must be signed in to change notification settings - Fork 9.4k
cviking26_issue-9489 // added query param to url build - description … #10848
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
| public function getEmailConfirmationUrl($email = null) | ||
| { | ||
| return $this->urlBuilder->getUrl('customer/account/confirmation', ['email' => $email]); | ||
| return $this->urlBuilder->getUrl('customer/account/confirmation', array('_query' => ['email' => $email])); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please use short array syntax ([] instead of array())
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ishakhsuvarov thank's. Adapted and pushed.
|
@cviking26 Thank you for the update. We are going to proceed with review and merge |
…into cviking26_issue-9489
- Test Updated
There is an error while click on "resend confirmation mail". The mail address will transfered without special chars like "+". This is important for the new gmail feature which provides simply adding aliases.
Fixed Issues
Preconditions
Steps to reproduce
Actual Result
customer/account/confirmation/email/[email protected]/- The Parameter email in url is not urlencoded, so the param is missing in the input field.Parameter on this page in input field is now "firstname.lastname [email protected]" without the plus
Expected result
customer/account/confirmation/email/firstname.lastname%[email protected]/so Parameter in input field is with "+" char e.g. "[email protected]"
Solution
Bug can solved simply adding "_query" in htdocs/vendor/magento/module-customer/Model/Url.php:221
return $this->urlBuilder->getUrl('customer/account/confirmation', array('_query' => ['email' => $email]));