Merge pull request #1493 from magento-engcom/develop-prs

[EngCom] Public Pull Requests
 - MAGETWO-75114: Deprecated Magento\Store\Model\Store::$_isAdminSecure #10877
 - MAGETWO-72539: cviking26_issue-9489 // added query param to url build - description … #10848

Author: ishakhsuvarov

app/code/Magento/Customer/Model/Url.php

@@ -237,7 +237,7 @@ public function getForgotPasswordUrl()
      */
     public function getEmailConfirmationUrl($email = null)
     {
-        return $this->urlBuilder->getUrl('customer/account/confirmation', ['email' => $email]);
+        return $this->urlBuilder->getUrl('customer/account/confirmation', ['_query' => ['email' => $email]]);
     }
 
     /**

app/code/Magento/Store/Model/Store.php

@@ -207,6 +207,7 @@ class Store extends AbstractExtensibleModel implements
      * Flag that shows that backend URLs are secure
      *
      * @var boolean|null
+     * @deprecated unused protected property
      */
     protected $_isAdminSecure = null;
 

dev/tests/integration/testsuite/Magento/Customer/Controller/AccountTest.php

@@ -304,8 +304,8 @@ public function testWithConfirmCreatePostAction()
         $this->assertSessionMessages(
             $this->equalTo([
                 'You must confirm your account. Please check your email for the confirmation link or '
-                    . '<a href="http://localhost/index.php/customer/account/confirmation/email/'
-                    . 'test2%40email.com/">click here</a> for a new link.'
+                    . '<a href="http://localhost/index.php/customer/account/confirmation/'
+                    . '?email=test2%40email.com">click here</a> for a new link.'
             ]),
             MessageInterface::TYPE_SUCCESS
         );