Skip to content

Product video doesn't play when it is not placed first in the sort order. #26709

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
aashan10 opened this issue Feb 5, 2020 · 27 comments
Closed
Assignees
Labels
Component: ConfigurableProduct Component: ProductVideo Issue: Clear Description Gate 2 Passed. Manual verification of the issue description passed Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development Priority: P3 May be fixed according to the position in the backlog. Progress: done Reported on 2.4.0 Indicates original Magento version for the Issue report. Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch Severity: S3 Affects non-critical data or functionality and does not force users to employ a workaround. Triage: Done Has been reviewed and prioritized during Triage with Product Managers

Comments

@aashan10
Copy link

aashan10 commented Feb 5, 2020

Preconditions (*)

  • Magento Version : 2.2.9

  • PHP 7.1.32

  • MySQL Ver 14.14 Distrib 5.7.28, for Linux (x86_64) using EditLine wrapper

  • Sample data is used.

Steps to reproduce

  1. Edit the simple product of a configurable product and add a product video. ( In our case, we have used Chaz Kangeroo Hoodie as Configurable Product and Chaz Kangeroo Hoodie-XS-Black as its simple product )
  2. The video used is https://www.youtube.com/watch?v=L4XjEuCPOJY.
  3. Now, sort the video in media gallery to make it seen anywhere but not the first position.
  4. Save the product.
  5. View the configurable product in storefront product details page.
  6. Click on the color swatch to view the simple product media gallery.
  7. Click the video thumbnail and play the video.

Imgur
Imgur

Expected result

  1. The video should play when clicked on the thumbnail.

Actual result

  1. Only the thumbnail image of the youtube video is visible.
  2. The video is not played if the video is not in the first position according to the sort order in admin panel.
    Imgur

Imgur

Imgur

Imgur

Addition Information

#26709 (comment)

I could easily reproduce the issue on the latest 2.4-develop
youtube_video_26709

@magento-deployment-service
Copy link

Thanks for opening this issue!

@m2-assistant
Copy link

m2-assistant bot commented Feb 5, 2020

Hi @aashan10. Thank you for your report.
To help us process this issue please make sure that you provided the following information:

  • Summary of the issue
  • Information on your environment
  • Steps to reproduce
  • Expected and actual results

Please make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce. To deploy vanilla Magento instance on our environment, please, add a comment to the issue:

@magento give me 2.4-develop instance - upcoming 2.4.x release

For more details, please, review the Magento Contributor Assistant documentation.

@aashan10 do you confirm that you were able to reproduce the issue on vanilla Magento instance following steps to reproduce?

  • yes
  • no

@magento-engcom-team magento-engcom-team added the Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed label Feb 5, 2020
@ajijshekh123 ajijshekh123 self-assigned this Feb 5, 2020
@m2-assistant
Copy link

m2-assistant bot commented Feb 5, 2020

Hi @ajijshekh123. Thank you for working on this issue.
In order to make sure that issue has enough information and ready for development, please read and check the following instruction: 👇

  • 1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).

    DetailsIf the issue has a valid description, the label Issue: Format is valid will be added to the issue automatically. Please, edit issue description if needed, until label Issue: Format is valid appears.

  • 2. Verify that issue has a meaningful description and provides enough information to reproduce the issue. If the report is valid, add Issue: Clear Description label to the issue by yourself.

  • 3. Add Component: XXXXX label(s) to the ticket, indicating the components it may be related to.

  • 4. Verify that the issue is reproducible on 2.4-develop branch

    Details- Add the comment @magento give me 2.4-develop instance to deploy test instance on Magento infrastructure.
    - If the issue is reproducible on 2.4-develop branch, please, add the label Reproduced on 2.4.x.
    - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!

  • 5. Add label Issue: Confirmed once verification is complete.

  • 6. Make sure that automatic system confirms that report has been added to the backlog.

@ajijshekh123
Copy link

Give me @magento give me 2.4-develop instance

@magento-engcom-team
Copy link
Contributor

Hi @ajijshekh123. Thank you for your request. I'm working on Magento 2.4-develop instance for you

@magento-engcom-team
Copy link
Contributor

Hi @ajijshekh123, here is your Magento instance.
Admin access: https://i-26709-2-4-develop.instances.magento-community.engineering/admin_723b
Login: d5dd5377 Password: 0ad3122db139
Instance will be terminated in up to 3 hours.

@ajijshekh123
Copy link

ajijshekh123 commented Feb 5, 2020

Hello @aashan10,
After clicking on a video, Youtube video is played properly.
See attached the video and Let me know which points are missing in my end or is it working fine.

Issue

Thanks.

@ajijshekh123 ajijshekh123 added Issue: Cannot Reproduce Cannot reproduce the issue on the latest `2.4-develop` branch Progress: needs update labels Feb 5, 2020
@matthew-muscat
Copy link
Contributor

@magento give me 2.4-develop instance

@magento-engcom-team
Copy link
Contributor

Hi @matthew-muscat. Thank you for your request. I'm working on Magento 2.4-develop instance for you

@magento-engcom-team
Copy link
Contributor

Hi @matthew-muscat, here is your Magento instance.
Admin access: https://i-26709-2-4-develop.instances.magento-community.engineering/admin_36ba
Login: c6016c60 Password: 7ca19cfdb748
Instance will be terminated in up to 3 hours.

@matthew-muscat
Copy link
Contributor

@ajijshekh123 — confirming i'm able to repeat the issue on Magento v2.3.4 and also the latest Magento 2.4-develop snapshot.

The behaviour specifically occurs when viewing a configurable product, making a selection of a specific configuration, which contains a video located in any area other than the first image position.

If the instance remains online, this can be viewed over at...
https://i-26709-2-4-develop.instances.magento-community.engineering/example-configurable-product.html

ezgif com-video-to-gif

@matthew-muscat
Copy link
Contributor

Upon further investigation, it appears that this issue is due to the data on the Magento_ProductVideo/js/fotorama-add-video-events widget

Specifically optionsVideoData looks to have the video data always set as the first object in the array of product media gallery assets.

It would appear the sort order of the gallery is not occurring in https://github.com/magento/magento2/blob/2.4-develop/app/code/Magento/ConfigurableProduct/Block/Plugin/Product/Media/Gallery.php#L62

@matthew-muscat matthew-muscat added Component: ConfigurableProduct Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch Component: ProductVideo Issue: Clear Description Gate 2 Passed. Manual verification of the issue description passed Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed and removed Issue: Cannot Reproduce Cannot reproduce the issue on the latest `2.4-develop` branch Progress: needs update labels Feb 25, 2020
@ghost ghost removed the Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed label Feb 25, 2020
@ghost
Copy link

ghost commented Feb 25, 2020

✅ Confirmed by @matthew-muscat
Thank you for verifying the issue! 👍 Your confirmation will help us to acknowledge and process this report.

@vishvesshah vishvesshah self-assigned this Feb 29, 2020
@m2-assistant
Copy link

m2-assistant bot commented Feb 29, 2020

Hi @vishvesshah. Thank you for working on this issue.
In order to make sure that issue has enough information and ready for development, please read and check the following instruction: 👇

  • 1. Verify that issue has all the required information. (Preconditions, Steps to reproduce, Expected result, Actual result).

    DetailsIf the issue has a valid description, the label Issue: Format is valid will be added to the issue automatically. Please, edit issue description if needed, until label Issue: Format is valid appears.

  • 2. Verify that issue has a meaningful description and provides enough information to reproduce the issue. If the report is valid, add Issue: Clear Description label to the issue by yourself.

  • 3. Add Component: XXXXX label(s) to the ticket, indicating the components it may be related to.

  • 4. Verify that the issue is reproducible on 2.4-develop branch

    Details- Add the comment @magento give me 2.4-develop instance to deploy test instance on Magento infrastructure.
    - If the issue is reproducible on 2.4-develop branch, please, add the label Reproduced on 2.4.x.
    - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!


@vishvesshah
Copy link

@magento give me 2.4-develop instance

@magento-engcom-team
Copy link
Contributor

Hi @vishvesshah. Thank you for your request. I'm working on Magento 2.4-develop instance for you

@sdzhepa sdzhepa added Priority: P3 May be fixed according to the position in the backlog. Severity: S3 Affects non-critical data or functionality and does not force users to employ a workaround. Triage: Done Has been reviewed and prioritized during Triage with Product Managers and removed Triage: Ready for Triage Issue is ready to me triaged with Product Manager labels May 6, 2020
@m2-community-project m2-community-project bot added Progress: PR Created Indicates that Pull Request has been created to fix issue and removed Progress: PR in progress labels Sep 24, 2020
@ghost ghost unassigned vishvesshah and ajijshekh123 Oct 8, 2020
@m2-community-project m2-community-project bot added Progress: PR Created Indicates that Pull Request has been created to fix issue and removed Progress: PR Created Indicates that Pull Request has been created to fix issue labels Oct 8, 2020
@magento-engcom-team magento-engcom-team added the Reported on 2.4.0 Indicates original Magento version for the Issue report. label Nov 13, 2020
@m2-community-project m2-community-project bot added Progress: PR in progress and removed Progress: PR Created Indicates that Pull Request has been created to fix issue labels Nov 13, 2020
@tuyennn
Copy link
Member

tuyennn commented Sep 30, 2022

#29690
#28875
#30938

Copy link

m2-assistant bot commented May 28, 2024

Hi @engcom-Delta. Thank you for working on this issue.
Looks like this issue is already verified and confirmed. But if you want to validate it one more time, please, go though the following instruction:

    1. Add/Edit Area: XXXXX label to the ticket, indicating the functional areas it may be related to.
    1. Verify that the issue is reproducible on 2.4-develop branch
      Details- Add the comment @magento give me 2.4-develop instance to deploy test instance on Magento infrastructure.
      - If the issue is reproducible on 2.4-develop branch, please, add the label Reproduced on 2.4.x.
      - If the issue is not reproducible, add your comment that issue is not reproducible and close the issue and stop verification process here!
    1. If the issue is not relevant or is not reproducible any more, feel free to close it.

@engcom-Delta
Copy link
Contributor

Hi @aashan10 ,

Thanks for your reporting and collaboration.

We have verified the issue in Latest 2.4-develop instance and the issue is no more reproducible.

Screenshot 2024-06-13 at 12 50 46 AM Screenshot 2024-06-13 at 12 50 55 AM Screenshot 2024-06-13 at 12 51 49 AM Screenshot 2024-06-13 at 12 54 32 AM Screenshot 2024-06-13 at 12 55 28 AM Screenshot 2024-06-13 at 1 05 07 AM Screenshot 2024-06-13 at 1 05 56 AM Screenshot 2024-06-13 at 1 06 05 AM Screenshot 2024-06-13 at 1 08 18 AM

Hence we are closing this issue.

Thanks,

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: ConfigurableProduct Component: ProductVideo Issue: Clear Description Gate 2 Passed. Manual verification of the issue description passed Issue: Confirmed Gate 3 Passed. Manual verification of the issue completed. Issue is confirmed Issue: Format is valid Gate 1 Passed. Automatic verification of issue format passed Issue: Ready for Work Gate 4. Acknowledged. Issue is added to backlog and ready for development Priority: P3 May be fixed according to the position in the backlog. Progress: done Reported on 2.4.0 Indicates original Magento version for the Issue report. Reproduced on 2.3.x The issue has been reproduced on latest 2.3 release Reproduced on 2.4.x The issue has been reproduced on latest 2.4-develop branch Severity: S3 Affects non-critical data or functionality and does not force users to employ a workaround. Triage: Done Has been reviewed and prioritized during Triage with Product Managers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

10 participants