Sorting galery media by position

[LucasCalazans]

Description

The gallery of configurable products is not showing the video correctly when the video position in the admin is changed.

Fixed Issues

1. Fixes Product video doesn't play when it is not placed first in the sort order. #26709: Product video doesn't play when it is not placed first in the sort order.

Manual testing scenarios

1. Create a configurable product with images in the parent product
2. Add images and a video in the gallery of a child product
3. Go to storefront, select the options of the child that has a video
4. Click on the thumb of the video
5. The video should appear in the gallery with a play button

https://www.loom.com/share/29ef24c26ea04a3d8cd2e03465f071e2

Contribution checklist

• Pull request has a meaningful description of its purpose
• All commits are accompanied by meaningful commit messages
• All new or changed code is covered with unit/integration tests (if applicable)
• All automated tests passed successfully (all builds are green)

[m2-assistant]

Hi @LucasCalazans. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

• @magento give me test instance - deploy test instance based on PR changes
• @magento give me 2.4-develop instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Guide documentation.

[LucasCalazans]

@magento give me test instance

[magento-engcom-team]

Hi @LucasCalazans. Thank you for your request. I'm working on Magento instance for you

[magento-engcom-team]

Hi @LucasCalazans, here is your new Magento instance.
Admin access: https://pr-27593.instances.magento-community.engineering/admin_9f69
Login: e7bd5e44 Password: 65d2e183d06a
Instance will be terminated in up to 3 hours.

[LucasCalazans]

@magento give me 2.4-develop instance

[magento-engcom-team]

Hi @LucasCalazans. Thank you for your request. I'm working on Magento 2.4-develop instance for you

[magento-engcom-team]

Hi @LucasCalazans, here is your Magento instance.
Admin access: https://i-27593-2-4-develop.instances.magento-community.engineering/admin_4a29
Login: 4660f735 Password: de1157b0f96f
Instance will be terminated in up to 3 hours.

[engcom-Alfa]

✔️ QA Passed

Manual testing scenario:

1. Edit the simple product of a configurable product and add a product video;
2. Save product;
3. Now, sort the video in the media gallery to make it seen anywhere but not the first position;
4. Save the product again;
5. View the configurable product in the storefront product details page.
6. Click on the color swatch to view the simple product media gallery.
7. Click the video thumbnail and play the video.

Before:
✖️ Only the thumbnail image of the youtube video is visible.
✖️ The video is not played if the video is not in the first position according to the sort order in admin panel.

After:
✔️ The video plays when you click on the thumbnail.

[engcom-Echo]

@magento run all tests

[engcom-Echo]

@magento run all tests

[engcom-Echo]

Need approval. Fixed type matching.
function getFormattedPrice() - app/code/Magento/Catalog/Model/Product.php

[engcom-Alfa]

Hi @LucasCalazans .

Could you resolve merge conflicts?
Thanks!

[ishakhsuvarov]

Hi @LucasCalazans

I am closing this PR for now as it seems like it has become stale and still needs work.

Please feel free to reopen if you wish to continue.

Thanks!