Skip to content

ISSUE-29690: Fixing issue when the images' sort was using ID instead of position field #30938

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Dec 24, 2020
Merged

ISSUE-29690: Fixing issue when the images' sort was using ID instead of position field #30938

merged 7 commits into from
Dec 24, 2020

Conversation

viniciusbordinhao-blueacorn
Copy link
Contributor

Description (*)

The issue was happening because the images were ordered by ID instead of position. Due to that some items that were supposed to be videos was interpreted like image.

Fixed Issues (if relevant)

  1. Fixes Magento 2 product YouTube video is not playing for the simple products within a configurable product #29690

Manual testing scenarios (*)

  1. See Magento 2 product YouTube video is not playing for the simple products within a configurable product #29690
  2. ./vendor/bin/phpunit app/code/Magento/ConfigurableProduct/Test/Unit/Block/Plugin/Product/Media/GalleryTest.php

Questions or comments

Those changes just fix the issues when the video is assigned to the main variant product, in other words, the first product related to the size. For instance, when the user clicks on a different colour, even if the product has the video, it is not showing. I think it is another issue related to the javascript, that I will fix soon and send a PR

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds are green)

@m2-assistant
Copy link

m2-assistant bot commented Nov 16, 2020

Hi @viniciusbordinhao-blueacorn. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento give me test instance - deploy test instance based on PR changes
  • @magento give me 2.4-develop instance - deploy vanilla Magento instance

❗ Automated tests can be triggered manually with an appropriate comment:

  • @magento run all tests - run or re-run all required tests against the PR changes
  • @magento run <test-build(s)> - run or re-run specific test build(s)
    For example: @magento run Unit Tests

<test-build(s)> is a comma-separated list of build names. Allowed build names are:

  1. Database Compare
  2. Functional Tests CE
  3. Functional Tests EE,
  4. Functional Tests B2B
  5. Integration Tests
  6. Magento Health Index
  7. Sample Data Tests CE
  8. Sample Data Tests EE
  9. Sample Data Tests B2B
  10. Static Tests
  11. Unit Tests
  12. WebAPI Tests

You can find more information about the builds here

ℹ️ Please run only needed test builds instead of all when developing. Please run all test builds before sending your PR for review.

For more details, please, review the Magento Contributor Guide documentation.

⚠️ According to the Magento Contribution requirements, all Pull Requests must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.

🕙 You can find the schedule on the Magento Community Calendar page.

📞 The triage of Pull Requests happens in the queue order. If you want to speed up the delivery of your contribution, please join the Community Contributions Triage session to discuss the appropriate ticket.

🎥 You can find the recording of the previous Community Contributions Triage on the Magento Youtube Channel

✏️ Feel free to post questions/proposals/feedback related to the Community Contributions Triage process to the corresponding Slack Channel

@m2-community-project m2-community-project bot added Priority: P3 May be fixed according to the position in the backlog. Severity: S2 Major restrictions or short-term circumventions are required until a fix is available. labels Nov 16, 2020
@viniciusbordinhao-blueacorn
Copy link
Contributor Author

@magento run all tests

@ihor-sviziev ihor-sviziev self-assigned this Nov 19, 2020
@ihor-sviziev
Copy link
Contributor

@magento run Functional Tests B2B, Functional Tests EE, Integration Tests

ihor-sviziev
ihor-sviziev requested changes Nov 19, 2020
View reviewed changes
Copy link
Contributor

@ihor-sviziev ihor-sviziev left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @viniciusbordinhao-blueacorn,
Could you cover your change with MFTF test as unit test isn't actually checking that issue isn't reproducing anymore?

@ihor-sviziev ihor-sviziev added Auto-Tests: Not Covered Changes in Pull Request requires coverage by auto-tests Progress: review and removed Progress: needs update labels Nov 19, 2020
@viniciusbordinhao-blueacorn
Copy link
Contributor Author

@ihor-sviziev

Sure, I will assign the task to me again. The Mtft tests will take some time but I will try to finish it next week.

  • EE tests and B2B tests are breaking, however, I do not even have those tests in my local environment. I am not sure how I could fix it.

@viniciusbordinhao-blueacorn
Copy link
Contributor Author

@magento run all tests

@ihor-sviziev ihor-sviziev added Auto-Tests: Covered All changes in Pull Request is covered by auto-tests Award: bug fix Award: MFTF test coverage Progress: review and removed Auto-Tests: Not Covered Changes in Pull Request requires coverage by auto-tests labels Dec 7, 2020
@engcom-Hotel
Copy link
Contributor

@magento run Functional Tests B2B

5 similar comments
@engcom-Hotel
Copy link
Contributor

@magento run Functional Tests B2B

@engcom-Hotel
Copy link
Contributor

@magento run Functional Tests B2B

@engcom-Hotel
Copy link
Contributor

@magento run Functional Tests B2B

@engcom-Hotel
Copy link
Contributor

@magento run Functional Tests B2B

@engcom-Hotel
Copy link
Contributor

@magento run Functional Tests B2B

@engcom-Delta engcom-Delta self-assigned this Dec 15, 2020
@engcom-Delta
Copy link
Contributor

✔️ QA passed
Manual testing sceanrio:

  • Create a configurable product containing 3 simple products that vary in color:

    • make sure to upload an image for each simple product and for the configurable product, then save the configurable product
      image

  • Now that the listing is published, add a YouTube video to each simple product and move it to the first position (to the left of the image).

  • Save product

  • Go to storefront

  • Open product detail page

Before:
❌ The video is just a thumbnail and cannot be played
Peek 2020-09-03 15-23

After:
✔️ The video of any options (i.e. simple products) within the configurable product is displayed.
Peek 2020-12-15 19-39

@engcom-Delta engcom-Delta added the QA: Added to Regression Scope Scenario was analysed and added to Regression Testing Scope label Dec 16, 2020
@engcom-Delta
Copy link
Contributor

Note: Automation tests are passed

@sidolov sidolov added Priority: P2 A defect with this priority could have functionality issues which are not to expectations. and removed Priority: P3 May be fixed according to the position in the backlog. labels Dec 22, 2020
@magento-engcom-team magento-engcom-team mentioned this pull request Dec 24, 2020
Closed
5 tasks
@m2-community-project m2-community-project bot added the Priority: P3 May be fixed according to the position in the backlog. label Dec 24, 2020
magento-engcom-team pushed a commit that referenced this pull request Dec 24, 2020
@sidolov
ENGCOM-8532: ISSUE-29690: Fixing issue when the images' sort was usin…
02ee4d7 
…g ID instead of position field #30938
@magento-engcom-team magento-engcom-team merged commit 6a2c40e into magento:2.4-develop Dec 24, 2020
@m2-assistant
Copy link

m2-assistant bot commented Dec 24, 2020

Hi @viniciusbordinhao-blueacorn, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@tuyennn tuyennn mentioned this pull request Sep 30, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@engcom-Hotel engcom-Hotel engcom-Hotel left review comments

@ihor-sviziev ihor-sviziev ihor-sviziev approved these changes

Assignees

@ihor-sviziev ihor-sviziev

@engcom-Delta engcom-Delta

@engcom-Hotel engcom-Hotel

Labels
Auto-Tests: Covered All changes in Pull Request is covered by auto-tests Award: bug fix Award: MFTF test coverage Component: ConfigurableProduct help wanted Partner: Blue Acorn iCi partners-contribution Pull Request is created by Magento Partner Priority: P2 A defect with this priority could have functionality issues which are not to expectations. Priority: P3 May be fixed according to the position in the backlog. Progress: accept QA: Added to Regression Scope Scenario was analysed and added to Regression Testing Scope Release Line: 2.4 Severity: S2 Major restrictions or short-term circumventions are required until a fix is available.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Magento 2 product YouTube video is not playing for the simple products within a configurable product
6 participants
@viniciusbordinhao-blueacorn @ihor-sviziev @engcom-Hotel @magento-engcom-team @engcom-Delta @sidolov