🔃 [EngCom] Public Pull Requests - 2.2-develop

Accepted Public Pull Requests:
 - #19036: #18323: Order confirmation email for guest checkout d� (by @swnsma)
 - #19012: #18348 - In admin, last swatch option set to default upon save (by @RostislavS)
 - #18964:  Backport [PR 18772] Remove unnecesary "header" block redeclaration (by @samuel27m)
 - #18857: Fixed - Default tax region/state appears in customer & order data #16684 (by @ssp58bleuciel)
 - #16887: Fix blocked a frame with origin (by @iGerchak)
 - magento-engcom/magento2ce#1169: #12970: Can't add grouped product, with out of stock sub product, to cart. (by @p-bystritsky)


Fixed GitHub Issues:
 - #18323: Order confirmation email for guest checkout does not include download links (reported by @hsray) has been fixed in #19036 by @swnsma in 2.2-develop branch
   Related commits:
     1. 429815b

 - #19003: salesInvoiceOrder REST API does not make downloadable products available (reported by @nthurston) has been fixed in #19036 by @swnsma in 2.2-develop branch
   Related commits:
     1. 429815b

 - #19034: sales_order_item_save_commit_after and sales_order_save_commit_after events will never fire for guest checkout (reported by @swnsma) has been fixed in #19036 by @swnsma in 2.2-develop branch
   Related commits:
     1. 429815b

 - #8348: 1 exception(s): Exception #0 (Exception): Warning: Invalid argument supplied for foreach() in NotProtectedExtension.php on line 89 (reported by @craigcarnell) has been fixed in #19012 by @RostislavS in 2.2-develop branch
   Related commits:
     1. 468f245
     2. 4c13ad7

 - #16684: Default tax region/state appears in customer & order data (reported by @Detzler) has been fixed in #18857 by @ssp58bleuciel in 2.2-develop branch
   Related commits:
     1. 5a84c5a
     2. e4b430a

 - #12970: Can't add grouped product, with out of stock sub product, to cart (reported by @breg-13) has been fixed in magento-engcom/magento2ce#1169 by @p-bystritsky in 2.2-develop branch
   Related commits:
     1. 7d44656
     2. 42b4f3c
     3. da05e92
     4. 40600b9
     5. 63c7fc9
     6. 26b6a27

Author: magento-engcom-team

app/code/Magento/Checkout/view/frontend/web/js/model/new-customer-address.js

@@ -25,6 +25,8 @@ define([
         if (countryId) {
             if (addressData.region && addressData.region['region_id']) {
                 regionId = addressData.region['region_id'];
+            } else if (!addressData['region_id']) {
+                regionId = undefined;
             } else if (countryId === window.checkoutConfig.defaultCountryId) {
                 regionId = window.checkoutConfig.defaultRegionId;
             }

app/code/Magento/Downloadable/etc/events.xml

@@ -6,10 +6,10 @@
  */
 -->
 <config xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:noNamespaceSchemaLocation="urn:magento:framework:Event/etc/events.xsd">
-    <event name="sales_order_item_save_commit_after">
+    <event name="sales_order_item_save_after">
         <observer name="downloadable_observer" instance="Magento\Downloadable\Observer\SaveDownloadableOrderItemObserver" />
     </event>
-    <event name="sales_order_save_commit_after">
+    <event name="sales_order_save_after">
         <observer name="downloadable_observer" instance="Magento\Downloadable\Observer\SetLinkStatusObserver" />
     </event>
     <event name="sales_model_service_quote_submit_success">

app/code/Magento/GroupedProduct/Model/Product/Type/Grouped.php

@@ -341,7 +341,7 @@ protected function getProductInfo(\Magento\Framework\DataObject $buyRequest, $pr
                 if ($isStrictProcessMode && !$subProduct->getQty()) {
                     return __('Please specify the quantity of product(s).')->render();
                 }
-                $productsInfo[$subProduct->getId()] = (int)$subProduct->getQty();
+                $productsInfo[$subProduct->getId()] = $subProduct->isSalable() ? (float)$subProduct->getQty() : 0;
             }
         }
 

app/code/Magento/PageCache/view/frontend/web/js/page-cache.js

@@ -6,9 +6,10 @@
 define([
     'jquery',
     'domReady',
+    'consoleLogger',
     'jquery/ui',
     'mage/cookies'
-], function ($, domReady) {
+], function ($, domReady, consoleLogger) {
     'use strict';
 
     /**
@@ -41,7 +42,9 @@ define([
          * @param {jQuery} element - Comment holder
          */
         (function lookup(element) {
-            var iframeHostName;
+            var iframeHostName,
+                contents,
+                elementContents;
 
             // prevent cross origin iframe content reading
             if ($(element).prop('tagName') === 'IFRAME') {
@@ -53,7 +56,30 @@ define([
                 }
             }
 
-            $(element).contents().each(function (index, el) {
+            /**
+             * Rewrite jQuery contents method
+             *
+             * @param {Object} el
+             * @returns {Object}
+             * @private
+             */
+            contents = function (el) {
+                return $.map(el, function (elem) {
+                    try {
+                        return $.nodeName(elem, 'iframe') ?
+                               elem.contentDocument || (elem.contentWindow ? elem.contentWindow.document : []) :
+                               $.merge([], elem.childNodes);
+                    } catch (e) {
+                        consoleLogger.error(e);
+
+                        return [];
+                    }
+                });
+            };
+
+            elementContents = contents($(element));
+
+            $.each(elementContents, function (index, el) {
                 switch (el.nodeType) {
                     case 1: // ELEMENT_NODE
                         lookup(el);

app/code/Magento/Swatches/view/adminhtml/web/js/product-attributes.js

@@ -439,6 +439,9 @@ define([
 
                 activePanel.find('table input')
                     .each(function () {
+                        if ($(this).is(':radio') && !$(this).prop('checked')) {
+                            return;
+                        }
                         swatchValues.push(this.name + '=' + $(this).val());
                     });
 

app/design/frontend/Magento/luma/Magento_Customer/layout/default.xml

@@ -15,11 +15,6 @@
                 </arguments>
             </block>
         </referenceBlock>
-        <block class="Magento\Theme\Block\Html\Header" name="header" as="header">
-            <arguments>
-                <argument name="show_part" xsi:type="string">welcome</argument>
-            </arguments>
-        </block>
         <move element="header" destination="header.links" before="-"/>
         <move element="register-link" destination="header.links"/>
         <move element="top.links" destination="customer"/>

dev/tests/integration/testsuite/Magento/Catalog/_files/product_virtual_out_of_stock.php

@@ -0,0 +1,20 @@
+<?php
+/**
+ * Copyright © Magento, Inc. All rights reserved.
+ * See COPYING.txt for license details.
+ */
+
+/** @var $product \Magento\Catalog\Model\Product */
+$product = \Magento\TestFramework\Helper\Bootstrap::getObjectManager()->create(\Magento\Catalog\Model\Product::class);
+$product->setTypeId(\Magento\Catalog\Model\Product\Type::TYPE_VIRTUAL)
+    ->setId(31)
+    ->setAttributeSetId(4)
+    ->setWebsiteIds([1])
+    ->setName('Virtual Product Out')
+    ->setSku('virtual-product-out')
+    ->setPrice(10)
+    ->setTaxClassId(0)
+    ->setVisibility(\Magento\Catalog\Model\Product\Visibility::VISIBILITY_BOTH)
+    ->setStatus(\Magento\Catalog\Model\Product\Attribute\Source\Status::STATUS_ENABLED)
+    ->setStockData(['is_in_stock' => 0])
+    ->save();

dev/tests/integration/testsuite/Magento/Catalog/_files/product_virtual_out_of_stock_rollback.php

@@ -0,0 +1,26 @@
+<?php
+/**
+ * Copyright © Magento, Inc. All rights reserved.
+ * See COPYING.txt for license details.
+ */
+
+/** @var \Magento\Framework\Registry $registry */
+$registry = \Magento\TestFramework\Helper\Bootstrap::getObjectManager()
+    ->get(\Magento\Framework\Registry::class);
+
+$registry->unregister('isSecureArea');
+$registry->register('isSecureArea', true);
+
+/** @var \Magento\Catalog\Api\ProductRepositoryInterface $productRepository */
+$productRepository = \Magento\TestFramework\Helper\Bootstrap::getObjectManager()
+    ->create(\Magento\Catalog\Api\ProductRepositoryInterface::class);
+
+try {
+    $product = $productRepository->get('virtual-product-out', false, null, true);
+    $productRepository->delete($product);
+} catch (\Magento\Framework\Exception\NoSuchEntityException $exception) {
+    //Product already removed
+}
+
+$registry->unregister('isSecureArea');
+$registry->register('isSecureArea', false);