Skip to content

Conversation

@RostislavS
Copy link
Contributor

@RostislavS RostislavS commented Nov 2, 2018

Description (*)

Fixed Issues (if relevant)

  1. 1 exception(s): Exception #0 (Exception): Warning: Invalid argument supplied for foreach() in NotProtectedExtension.php on line 89 #8348: In admin, last swatch option set to default upon save

Manual testing scenarios (*)

  1. According to the issue, admin cannot change the default swatch option. PR fixes this ability.

Contribution checklist (*)

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

@magento-cicd2
Copy link
Contributor

magento-cicd2 commented Nov 2, 2018

CLA assistant check
All committers have signed the CLA.

@magento-engcom-team
Copy link
Contributor

Hi @RostislavS. Thank you for your contribution
Here is some useful tips how you can test your changes using Magento test environment.
Add the comment under your pull request to deploy test or vanilla Magento instance:

  • @magento-engcom-team give me test instance - deploy test instance based on PR changes
  • @magento-engcom-team give me $VERSION instance - deploy vanilla Magento instance

For more details, please, review the Magento Contributor Assistant documentation

@sivaschenko
Copy link
Member

Hi @RostislavS, thank you for the pull request. Can you please provide a verbose title/description for the pull request and also sign a Contributor Licence Agreement (see comments above), so that this pull request can be processed further.
Thanks in advance!

@RostislavS RostislavS changed the title Issue18348 #18348 - In admin, last swatch option set to default upon save Nov 2, 2018
@VladimirZaets VladimirZaets self-assigned this Nov 2, 2018
@magento-engcom-team magento-engcom-team added this to the Release: 2.2.8 milestone Nov 5, 2018
@magento-engcom-team
Copy link
Contributor

Hi @VladimirZaets, thank you for the review.
ENGCOM-3383 has been created to process this Pull Request

@magento-engcom-team
Copy link
Contributor

Hi @RostislavS. Thank you for your contribution.
We will aim to release these changes as part of 2.2.8.
Please check the release notes for final confirmation.

Please, consider to port this solution to 2.3 release line.
You may use Porting tool to port commits automatically.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants