Skip to content

MFTF 2.5.2 Release #494

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 78 commits into from
Oct 23, 2019
Merged

MFTF 2.5.2 Release #494

merged 78 commits into from
Oct 23, 2019

Conversation

soumyau
Copy link
Contributor

@soumyau soumyau commented Oct 21, 2019

Description

MFTF 2.5.2 patch release.

Fixed Issues

  • MQE-610 [PHPMD] Reduce Cyclomatic Complexity in Problem Methods
  • MQE-1510 MFTF magentoCLI shell command fix
  • MQE-1650 Update MFTF configuration to read Test entities from new location
  • MQE-1734 Add base + merge files to Test Description
  • MQE-1763 Investigate and fix failure due to absence of AcceptanceTester class
  • MQE-1773 [Community] executeInSelenium generation fix
  • MQE-1831 Remove Deprecation warning from Module Resolver

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/verification tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)
  • Changes to Framework doesn't have backward incompatible changes for tests or have related Pull Request with fixes to tests

zakdma and others added 30 commits May 6, 2019 16:23
Mqe 1754 mftf generate:tests AdminLoginTest -f does not obey the -f flag
MQE-1763: Investigate and fix failure due to absence of AcceptanceTester class
Refactored to keep Cyclomatic complexity <= 10.
Added comments to below files to refactor later
** Config/FileResolver/Module.php
** Config/Converter.php
** Config/Dom.php
Refactored to keep Cyclomatic complexity <= 10.
Added comments to functions that are not refactored for readability
KevinBKozan and others added 20 commits October 3, 2019 11:37
executeInSelenium generation fix #2
Add details for changing settings via command line
MQE-1831: Remove Deprecation warning from Module Resolver
…cation

- Reduced requirements of composer.json to 1.4 (magento 2.2)
MQE-1650: update MFTF configuration to read Test entities from new location
@coveralls
Copy link

coveralls commented Oct 21, 2019

Coverage Status

Coverage increased (+1.9%) to 53.87% when pulling 449f5e4 on MFTF-2.5.2-RC into 49a16cb on master.

CHANGELOG.md Outdated
* Refactored problem methods to reduce cyclomatic complexity.

### Fixes
* Added escaping for `magentoCLI` commands.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove this line, users should not be impacted by this change

@KevinBKozan KevinBKozan merged commit e254e73 into master Oct 23, 2019
@KevinBKozan KevinBKozan deleted the MFTF-2.5.2-RC branch December 6, 2019 19:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants