Skip to content

MQE-1510 #469

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Oct 3, 2019
Merged

MQE-1510 #469

merged 5 commits into from
Oct 3, 2019

Conversation

KevinBKozan
Copy link
Contributor

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/verification tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)
  • Changes to Framework doesn't have backward incompatible changes for tests or have related Pull Request with fixes to tests

@coveralls
Copy link

Coverage Status

Coverage increased (+0.7%) to 53.546% when pulling 6ed2be4 on MQE-1510 into 17082a1 on develop.

@coveralls
Copy link

coveralls commented Sep 25, 2019

Coverage Status

Coverage increased (+0.3%) to 53.394% when pulling d21fa29 on MQE-1510 into 02902f9 on develop.

@soumyau soumyau self-requested a review September 26, 2019 21:00
Copy link
Contributor

@soumyau soumyau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

escapeshellcmd usage seems to skip the command run in its entirety if there are escape sequences involved. AC + implementation needs to be discussed/modified based on whether we intend to fail the test with a specific http response code or find a way to execute just the original magento command.

@KevinBKozan
Copy link
Contributor Author

@soumyau I added a check to see if escapeshellcmd made any difference to the command. That should give faster feedback on if the command is. I'm running builds to ensure this doesn't break existing tests.

That said, I'm still going to continue trying to figure out why exactly symfony is just hiding the error.

– Reverting command check
Copy link
Contributor

@soumyau soumyau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Invalid formats in cli commands throw 500 error now.

@KevinBKozan KevinBKozan merged commit 5ee8dda into develop Oct 3, 2019
@KevinBKozan KevinBKozan deleted the MQE-1510 branch October 3, 2019 18:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants