Skip to content

MQE-1763: Investigate and fix failure due to absence of AcceptanceTester class #460

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Sep 20, 2019

Conversation

tomreece
Copy link
Contributor

Description

This bug was reproducible on branches that had updated the symfony/yaml package in composer from v3.4.30 to v4.3.4. The updated package was less forgiving about our functional.suite.yml file which did not properly quote string values in some cases.

This PR only exists to ensure that in the future we get better output from the mftf build:project command. This output was hidden in the Jenkins job because the --verbose flag was not used. If we had that output in Jenkins, then this bug would have been trivial to identify.

I also added troubleshooting steps to devdocs for users on versions lower than MFTF 2.5.0.

TLDR: No bug here. I increased output from mftf build:project and wrote some docs.

Fixed Issues (if relevant)

  1. https://jira.corp.magento.com/browse/MQE-1763

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/verification tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)
  • Changes to Framework doesn't have backward incompatible changes for tests or have related Pull Request with fixes to tests

@tomreece tomreece requested a review from dobooth September 19, 2019 15:07
@@ -2,60 +2,64 @@

Having a little trouble with the MFTF? See some common errors and fixes below.

## WebDriver issues
Copy link
Contributor Author

@tomreece tomreece Sep 19, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This documentation change looks more complicated than it is.

I discussed with @dobooth and we agreed to remove the two existing troubleshooting items on this page because they were no longer relevant.

Removed those two sections
Added a section about this AcceptanceTester bug

Copy link
Contributor

@jilu1 jilu1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Root cause of the issue is already fixed. This code change is to allow better logging for future issue and it looks good.

@tomreece tomreece merged commit e850699 into develop Sep 20, 2019
@dobooth dobooth deleted the MQE-1763 branch October 29, 2019 18:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants