Skip to content

MQE-1750: unit tests #476

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Oct 9, 2019
Merged

MQE-1750: unit tests #476

merged 6 commits into from
Oct 9, 2019

Conversation

jilu1
Copy link
Contributor

@jilu1 jilu1 commented Oct 2, 2019

Description

Fixed Issues (if relevant)

  1. magento/magento2-functional-testing-framework#<issue_number>: Issue title
  2. ...

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/verification tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)
  • Changes to Framework doesn't have backward incompatible changes for tests or have related Pull Request with fixes to tests

@coveralls
Copy link

Coverage Status

Coverage increased (+0.7%) to 53.877% when pulling 9f6cffc on MQE-1750 into 02902f9 on develop.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage increased (+0.7%) to 53.877% when pulling 9f6cffc on MQE-1750 into 02902f9 on develop.

@coveralls
Copy link

coveralls commented Oct 2, 2019

Coverage Status

Coverage increased (+0.5%) to 53.066% when pulling 68c5576 on MQE-1750 into 5ee8dda on develop.

*
* @var ComposerInstall
*/
private static $composer;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's change this to just be private $composer; and change setUpBeforeClass() to just setUp().

Since this is initialized only once in the test, the object's state is subject to change due to test's manipulation, which set a bad pattern if we ever do any state tracking in that class in the future.

Also being the class under test, we should really initialize once per test.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed

*
* @var ComposerPackage
*/
private static $composer;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comment above.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed

Copy link
Contributor

@KevinBKozan KevinBKozan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unit tests look good to me!

Diffed before/after of magento2ce enabledDirectoryPaths and no difference detected, nice work 👍

KevinBKozan
KevinBKozan previously approved these changes Oct 8, 2019
@jilu1 jilu1 merged commit 1671bcd into develop Oct 9, 2019
@jilu1 jilu1 deleted the MQE-1750 branch February 6, 2020 16:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants