Skip to content

MQE-1456: The "amOnPage" action always waits the entire timeout value before proceeding to the next action. #330

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Apr 19, 2019

Conversation

ivy00johns
Copy link
Contributor

Description

  • This PR contains 1 new Action for amOnPage that overrides the latest version of the action listed in MagentoWebDriver.php.
  • The version of amOnPage listed in MagentoWebDriver.php contains waitForPageLoad which is NOT compatible with the Venia PWA.

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/verification tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)
  • Changes to Framework doesn't have backward incompatible changes for tests or have related Pull Request with fixes to tests

…'amOnPage' action always waits for the full timeout value.

- Adding new action to MagentoPwaWebDriver for "amOnPage".
@coveralls
Copy link

coveralls commented Apr 11, 2019

Coverage Status

Coverage increased (+1.5%) to 56.991% when pulling 8d63600 on MQE-1456-amOnPage-Always-Waits into 24ac1d9 on develop.

@ivy00johns
Copy link
Contributor Author

Copy link
Contributor

@jilu1 jilu1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change for "amOnPage" looks good to me. However, it looks like you might have similar problem for actions like selectMultipleOptions() and searchAndMultiSelectOption(). Can you please double check?

@ivy00johns
Copy link
Contributor Author

I looked over the logic for selectMultipleOptions()/searchAndMultiSelectOption() and their logic applies to the Magento Admin. At the current time the Storefront cannot use these actions, they are Admin specific.

@ivy00johns ivy00johns merged commit c9dd418 into develop Apr 19, 2019
@ivy00johns ivy00johns deleted the MQE-1456-amOnPage-Always-Waits branch June 4, 2019 19:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants