Skip to content

Commit c9dd418

Browse files
authored
Merge pull request #330 from magento/MQE-1456-amOnPage-Always-Waits
MQE-1456: The "amOnPage" action always waits the entire timeout value before proceeding to the next action.
2 parents 24ac1d9 + 8d63600 commit c9dd418

File tree

1 file changed

+17
-0
lines changed

1 file changed

+17
-0
lines changed

src/Magento/FunctionalTestingFramework/Module/MagentoPwaWebDriver.php

Lines changed: 17 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,8 @@
66

77
namespace Magento\FunctionalTestingFramework\Module;
88

9+
use Codeception\Module\WebDriver;
10+
911
/**
1012
* Class MagentoPwaActions
1113
*
@@ -15,6 +17,21 @@
1517
*/
1618
class MagentoPwaWebDriver extends MagentoWebDriver
1719
{
20+
/**
21+
* Go to the page.
22+
*
23+
* Overriding the MagentoWebDriver version because it contains 'waitForPageLoad'.
24+
* The AJAX check in 'waitForPageLoad' does NOT work with a PWA.
25+
*
26+
* @param string $page
27+
* @throws \Exception
28+
* @return void
29+
*/
30+
public function amOnPage($page)
31+
{
32+
WebDriver::amOnPage($page);
33+
}
34+
1835
/**
1936
* Wait for a PWA Element to NOT be visible using JavaScript.
2037
* Add the WAIT_TIMEOUT variable to your .env file for this action.

0 commit comments

Comments
 (0)